fix(copilot): only fold registry-known types into final batch state

Pass 1 recorded any non-empty type into finalType, but apply skips type changes to unknown types (keeps the existing block). An unknown type on an earlier op could poison a later type-less apiKey edit. Only advance finalType to a getBlock-resolvable type so the fallback matches what apply persists. Test covers empty and unknown types.

Author: TheodoreSpeaks

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.test.ts

@@ -676,30 +676,33 @@ describe('preValidateCredentialInputs (hosted-tool blocks)', () => {
     expect(result.errors[0]).toMatchObject({ blockId: 'video-1', field: 'apiKey' })
   })
 
-  it('does not let a bogus type on an earlier op block stripping on a later edit', async () => {
-    const operations = [
-      {
-        operation_type: 'edit' as const,
-        block_id: 'video-1',
-        params: { type: '', inputs: { prompt: 'x' } },
-      },
-      {
-        operation_type: 'edit' as const,
-        block_id: 'video-1',
-        params: { inputs: { apiKey: '{{FAL_API_KEY}}' } },
-      },
-    ]
-    const workflowState = {
-      blocks: {
-        'video-1': { type: 'video_generator_v3', subBlocks: { provider: { value: 'falai' } } },
-      },
-    }
+  it.each([{ type: '' }, { type: 'totally_unknown_type' }])(
+    'does not let an invalid type (%o) on an earlier op block stripping on a later edit',
+    async ({ type }) => {
+      const operations = [
+        {
+          operation_type: 'edit' as const,
+          block_id: 'video-1',
+          params: { type, inputs: { prompt: 'x' } },
+        },
+        {
+          operation_type: 'edit' as const,
+          block_id: 'video-1',
+          params: { inputs: { apiKey: '{{FAL_API_KEY}}' } },
+        },
+      ]
+      const workflowState = {
+        blocks: {
+          'video-1': { type: 'video_generator_v3', subBlocks: { provider: { value: 'falai' } } },
+        },
+      }
 
-    const result = await preValidateCredentialInputs(operations, ctx, workflowState)
+      const result = await preValidateCredentialInputs(operations, ctx, workflowState)
 
-    expect(result.filteredOperations[1]?.params?.inputs?.apiKey).toBeUndefined()
-    expect(result.errors).toHaveLength(1)
-  })
+      expect(result.filteredOperations[1]?.params?.inputs?.apiKey).toBeUndefined()
+      expect(result.errors).toHaveLength(1)
+    }
+  )
 
   it('uses same-batch state: a type-less apiKey edit after an earlier op makes the block hosted', async () => {
     // op1 switches provider to falai (hosted); op2 (type-less) sets apiKey. op2 must see op1's

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.ts

@@ -1463,7 +1463,11 @@ export async function preValidateCredentialInputs(
       const priorType = finalType.has(stateKey)
         ? finalType.get(stateKey)
         : (snapshotBlock(stateKey)?.type as string | undefined)
-      const resolved = validType(rawType) ?? priorType
+      // Only advance the type to one apply will honor: a registry-known type. An unknown type
+      // (apply skips the change and keeps the existing block) must not poison the fallback, or a
+      // later type-less apiKey edit would be judged against a block config that never applies.
+      const candidate = validType(rawType)
+      const resolved = (candidate && getBlock(candidate) ? candidate : undefined) ?? priorType
       if (resolved) finalType.set(stateKey, resolved)
       if (isHosted) {
         const priorValues =