fix(copilot): tool selector throw falls back to access tools (fail toward strip)

Symmetric with the enabled-throw fix: when tools.config.tool throws on partial params, scan all access tools instead of returning, so a hosted key can't slip through. Test added.

Author: TheodoreSpeaks

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.test.ts

@@ -123,6 +123,22 @@ const throwGateBlockConfig = {
   tools: { access: ['throw_gate_tool'], config: { tool: () => 'throw_gate_tool' } },
 }
 
+// Block whose tool selector throws — should fall back to scanning access tools (video_falai).
+const throwSelectorBlockConfig = {
+  type: 'throw_selector_block',
+  name: 'Throw Selector Block',
+  outputs: {},
+  subBlocks: [{ id: 'provider', type: 'dropdown' }],
+  tools: {
+    access: ['video_falai'],
+    config: {
+      tool: () => {
+        throw new Error('selector boom')
+      },
+    },
+  },
+}
+
 // Tool registry stand-in for the hosted-tool tests.
 const toolsByIdMock: Record<string, unknown> = {
   video_falai: { id: 'video_falai', hosting: { apiKeyParam: 'apiKey' } },
@@ -170,7 +186,9 @@ vi.mock('@/blocks/registry', () => ({
                         ? imageBlockConfig
                         : type === 'throw_gate_block'
                           ? throwGateBlockConfig
-                          : undefined,
+                          : type === 'throw_selector_block'
+                            ? throwSelectorBlockConfig
+                            : undefined,
 }))
 
 vi.mock('@/blocks/utils', () => ({
@@ -714,6 +732,24 @@ describe('preValidateCredentialInputs (hosted-tool blocks)', () => {
     expect(result.errors[0]).toMatchObject({ blockId: 'video-1', field: 'apiKey' })
   })
 
+  it('strips apiKey when the tool selector throws (falls back to access tools)', async () => {
+    const operations = [
+      {
+        operation_type: 'add' as const,
+        block_id: 'sel-1',
+        params: {
+          type: 'throw_selector_block',
+          inputs: { provider: 'falai', apiKey: 'user-key' },
+        },
+      },
+    ]
+
+    const result = await preValidateCredentialInputs(operations, ctx)
+
+    expect(result.filteredOperations[0]?.params?.inputs?.apiKey).toBeUndefined()
+    expect(result.errors).toHaveLength(1)
+  })
+
   it('strips apiKey when a tool hosting enabled predicate throws (fail toward stripping)', async () => {
     const operations = [
       {

apps/sim/lib/copilot/tools/server/workflow/edit-workflow/validation.ts

@@ -1332,17 +1332,19 @@ export async function preValidateCredentialInputs(
     if (!isHosted || !blockConfig?.tools) return
 
     // Resolve which tool(s) the current inputs select. With a selector there is exactly one active
-    // tool; without one, every accessible tool is a candidate.
+    // tool; without one (or if the selector throws on partial params), every accessible tool is a
+    // candidate — failing toward considering all hosted params so a key can't slip through.
+    const accessToolIds = blockConfig.tools.access ?? []
     let candidateToolIds: string[]
     const toolSelector = blockConfig.tools.config?.tool
     if (toolSelector) {
       try {
         candidateToolIds = [toolSelector(toolParams)]
       } catch {
-        return
+        candidateToolIds = accessToolIds
       }
     } else {
-      candidateToolIds = blockConfig.tools.access ?? []
+      candidateToolIds = accessToolIds
     }
 
     const managedFieldIds = new Set<string>()