fix(triggers): require a positive signal in Twilio matchEvent routing

Previously an empty MessageStatus/SmsStatus was treated as a status callback,
so an ambiguous or partial payload could match twilio_sms_status (or skip
twilio_sms_received). Both triggers now require a positive signal — inbound
needs status 'received', status callbacks need a non-'received' status — so a
payload missing both fields matches neither rather than misrouting.

Author: waleedlatif1

apps/sim/lib/webhooks/providers/twilio.test.ts

@@ -175,6 +175,12 @@ describe('twilioHandler', () => {
     it('passes through when no triggerId is configured', () => {
       expect(match('', inbound)).toBe(true)
     })
+
+    it('matches neither trigger for an ambiguous payload missing status fields', () => {
+      const ambiguous = { MessageSid: 'SM1', From: '+1' }
+      expect(match('twilio_sms_received', ambiguous)).toBe(false)
+      expect(match('twilio_sms_status', ambiguous)).toBe(false)
+    })
   })
 
   describe('formatInput', () => {

apps/sim/lib/webhooks/providers/twilio.ts

@@ -28,17 +28,21 @@ export const twilioHandler: WebhookProviderHandler = {
   /**
    * Distinguish an inbound SMS from a delivery status callback so the two
    * triggers don't fire on each other's deliveries when they share a URL.
-   * Twilio reports `SmsStatus: 'received'` for inbound messages; status
-   * callbacks carry a delivery `MessageStatus` (queued/sent/delivered/…).
+   * Twilio reports status `received` for inbound messages; delivery callbacks
+   * carry a non-`received` `MessageStatus` (queued/sent/delivered/…). Each side
+   * requires a positive signal, so an ambiguous payload missing both fields
+   * matches neither trigger rather than misrouting.
    */
   matchEvent({ body, providerConfig }: EventMatchContext) {
     const triggerId = providerConfig.triggerId as string | undefined
     if (!triggerId) return true
     const b = body as Record<string, unknown>
-    const status = (((b.MessageStatus as string) || (b.SmsStatus as string)) ?? '').toLowerCase()
-    const isInbound = status === 'received'
+    const messageStatus = ((b.MessageStatus as string) ?? '').toLowerCase()
+    const smsStatus = ((b.SmsStatus as string) ?? '').toLowerCase()
+    const isInbound = smsStatus === 'received' || messageStatus === 'received'
+    const isStatusCallback = !isInbound && (messageStatus !== '' || smsStatus !== '')
     if (triggerId === 'twilio_sms_received') return isInbound
-    if (triggerId === 'twilio_sms_status') return !isInbound
+    if (triggerId === 'twilio_sms_status') return isStatusCallback
     return true
   },