fix(triggers): key Twilio status callbacks by SID + status for idempotency

Twilio sends multiple delivery callbacks per message (sent -> delivered -> ...)
sharing one MessageSid; keying idempotency on the SID alone dropped every status
after the first. Status callbacks now key on SID + delivery status so each state
is distinct (while still deduping Twilio's retries of the same status); inbound
messages still key by SID since they fire once.

Author: waleedlatif1

apps/sim/lib/webhooks/providers/twilio.test.ts

@@ -128,10 +128,23 @@ describe('twilioHandler', () => {
 
   describe('extractIdempotencyId', () => {
     it('prefers MessageSid, falls back to CallSid', () => {
-      expect(twilioHandler.extractIdempotencyId!({ MessageSid: 'SM1' })).toBe('SM1')
+      expect(
+        twilioHandler.extractIdempotencyId!({ MessageSid: 'SM1', SmsStatus: 'received' })
+      ).toBe('SM1')
       expect(twilioHandler.extractIdempotencyId!({ CallSid: 'CA1' })).toBe('CA1')
       expect(twilioHandler.extractIdempotencyId!({})).toBeNull()
     })
+
+    it('keys status callbacks by SID + status so each delivery state is distinct', () => {
+      const sent = twilioHandler.extractIdempotencyId!({ MessageSid: 'SM1', MessageStatus: 'sent' })
+      const delivered = twilioHandler.extractIdempotencyId!({
+        MessageSid: 'SM1',
+        MessageStatus: 'delivered',
+      })
+      expect(sent).toBe('SM1:sent')
+      expect(delivered).toBe('SM1:delivered')
+      expect(sent).not.toBe(delivered)
+    })
   })
 
   describe('matchEvent', () => {

apps/sim/lib/webhooks/providers/twilio.ts

@@ -44,7 +44,17 @@ export const twilioHandler: WebhookProviderHandler = {
 
   extractIdempotencyId(body: unknown) {
     const obj = body as Record<string, unknown>
-    return (obj.MessageSid as string) || (obj.CallSid as string) || null
+    const sid = (obj.MessageSid as string) || (obj.CallSid as string)
+    if (!sid) return null
+    // Status callbacks repeat for the same SID as the message progresses
+    // (sent -> delivered -> ...), so the delivery status is part of the key to
+    // keep each distinct callback (while still deduping Twilio's retries of the
+    // same status). Inbound messages fire once (SmsStatus 'received'), keyed by SID.
+    const status = (
+      ((obj.MessageStatus as string) || (obj.SmsStatus as string)) ??
+      ''
+    ).toLowerCase()
+    return status && status !== 'received' ? `${sid}:${status}` : sid
   },
 
   async formatInput({ body }: FormatInputContext): Promise<FormatInputResult> {