short array syntax (#43) #213
php.yml
on: push
Annotations
16 errors and 16 warnings
UnusedVariable:
config-templates/module_metarefresh.php#L3
config-templates/module_metarefresh.php:3:1: UnusedVariable: $config is never referenced or the value is not used (see https://psalm.dev/077)
|
RedundantCondition:
src/ARP.php#L39
src/ARP.php:39:13: RedundantCondition: Type string for $attributemap_filename is never null (see https://psalm.dev/122)
|
RiskyTruthyFalsyComparison:
src/MetaLoader.php#L66
src/MetaLoader.php:66:14: RiskyTruthyFalsyComparison: Operand of type array<array-key, mixed>|null contains type array<array-key, mixed>, which can be falsy and truthy. This can cause possibly unexpected behavior. Use strict comparison instead. (see https://psalm.dev/356)
|
PossiblyUndefinedArrayOffset:
src/MetaLoader.php#L122
src/MetaLoader.php:122:52: PossiblyUndefinedArrayOffset: Possibly undefined array key $source['src'] on array<array-key, mixed> (see https://psalm.dev/167)
|
PossiblyUndefinedArrayOffset:
src/MetaLoader.php#L132
src/MetaLoader.php:132:46: PossiblyUndefinedArrayOffset: Possibly undefined array key $source['src'] on array<array-key, mixed> (see https://psalm.dev/167)
|
PossiblyUndefinedVariable:
src/MetaLoader.php#L149
src/MetaLoader.php:149:40: PossiblyUndefinedVariable: Possibly undefined variable $data defined in try block (see https://psalm.dev/018)
|
PossiblyFalseArgument:
src/MetaLoader.php#L149
src/MetaLoader.php:149:40: PossiblyFalseArgument: Argument 1 of SimpleSAML\Module\metarefresh\MetaLoader::loadXML cannot be false, possibly string value expected (see https://psalm.dev/104)
|
InvalidArgument:
src/MetaLoader.php#L201
src/MetaLoader.php:201:25: InvalidArgument: Argument 2 of SimpleSAML\Module\metarefresh\MetaLoader::addMetadata expects array<array-key, SAML2\XML\md\AttributeAuthorityDescriptor>|null, but SAML2\XML\md\AttributeAuthorityDescriptor provided (see https://psalm.dev/004)
|
ArgumentTypeCoercion:
src/MetaLoader.php#L346
src/MetaLoader.php:346:50: ArgumentTypeCoercion: Argument 1 of preg_grep expects non-empty-string, but parent type string provided (see https://psalm.dev/193)
|
ArgumentTypeCoercion:
src/MetaLoader.php#L369
src/MetaLoader.php:369:32: ArgumentTypeCoercion: Argument 1 of preg_match expects non-empty-string, but parent type string provided (see https://psalm.dev/193)
|
UnusedClass:
tests/src/ARPTest.php#L11
tests/src/ARPTest.php:11:7: UnusedClass: Class SimpleSAML\Test\Module\metarefresh\ARPTest is never used (see https://psalm.dev/075)
|
UnusedClass:
tests/src/Controller/MetaRefreshTest.php#L17
tests/src/Controller/MetaRefreshTest.php:17:7: UnusedClass: Class SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest is never used (see https://psalm.dev/075)
|
UnnecessaryVarAnnotation:
tests/src/Controller/MetaRefreshTest.php#L101
tests/src/Controller/MetaRefreshTest.php:101:18: UnnecessaryVarAnnotation: The @var SimpleSAML\XHTML\Template annotation for $response is unnecessary (see https://psalm.dev/212)
|
UnusedClass:
tests/src/MetaLoaderTest.php#L11
tests/src/MetaLoaderTest.php:11:7: UnusedClass: Class SimpleSAML\Test\Module\metarefresh\MetaLoaderTest is never used (see https://psalm.dev/075)
|
UnusedIssueHandlerSuppression:
psalm-dev.xml#L1
/home/runner/work/simplesamlphp-module-metarefresh/simplesamlphp-module-metarefresh/psalm-dev.xml:0:0: UnusedIssueHandlerSuppression: Suppressed issue type "UnresolvableInclude" for /tests/bootstrap.php was not thrown. (see https://psalm.dev/326)
|
Quality control
Process completed with exit code 2.
|
Security checks
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Linter
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
Quality control
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
|
UnusedClass:
src/Controller/MetaRefresh.php#L22
src/Controller/MetaRefresh.php:22:7: UnusedClass: Class SimpleSAML\Module\metarefresh\Controller\MetaRefresh is never used (see https://psalm.dev/075)
|
PossiblyUnusedMethod:
src/MetaLoader.php#L77
src/MetaLoader.php:77:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\metarefresh\MetaLoader::getTypes (see https://psalm.dev/087)
|
PossiblyUnusedMethod:
src/MetaLoader.php#L495
src/MetaLoader.php:495:21: PossiblyUnusedMethod: Cannot find any calls to method SimpleSAML\Module\metarefresh\MetaLoader::dumpMetadataStdOut (see https://psalm.dev/087)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L20
tests/src/Controller/MetaRefreshTest.php:20:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authsources is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L23
tests/src/Controller/MetaRefreshTest.php:23:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L26
tests/src/Controller/MetaRefreshTest.php:26:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$module_config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/Controller/MetaRefreshTest.php#L29
tests/src/Controller/MetaRefreshTest.php:29:15: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::$authUtils is not defined in constructor of SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest or in any methods called in the constructor (see https://psalm.dev/074)
|
MissingReturnType:
tests/src/Controller/MetaRefreshTest.php#L89
tests/src/Controller/MetaRefreshTest.php:89:21: MissingReturnType: Method SimpleSAML\Test\Module\metarefresh\Controller\MetaRefreshTest::testMetaRefresh does not have a return type, expecting void (see https://psalm.dev/050)
|
MissingPropertyType:
tests/src/MetaLoaderTest.php#L14
tests/src/MetaLoaderTest.php:14:13: MissingPropertyType: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$metaloader does not have a declared type - consider SimpleSAML\Module\metarefresh\MetaLoader|null (see https://psalm.dev/045)
|
PropertyNotSetInConstructor:
tests/src/MetaLoaderTest.php#L17
tests/src/MetaLoaderTest.php:17:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$config is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
PropertyNotSetInConstructor:
tests/src/MetaLoaderTest.php#L20
tests/src/MetaLoaderTest.php:20:13: PropertyNotSetInConstructor: Property SimpleSAML\Test\Module\metarefresh\MetaLoaderTest::$tmpdir is not defined in constructor of SimpleSAML\Test\Module\metarefresh\MetaLoaderTest or in any private or final methods called in the constructor (see https://psalm.dev/074)
|
PossiblyFalseArgument:
tests/src/MetaLoaderTest.php#L92
tests/src/MetaLoaderTest.php:92:33: PossiblyFalseArgument: Argument 1 of array_diff cannot be false, possibly array<array-key, mixed> value expected (see https://psalm.dev/104)
|
PossiblyFalsePropertyAssignmentValue:
tests/src/MetaLoaderTest.php#L131
tests/src/MetaLoaderTest.php:131:25: PossiblyFalsePropertyAssignmentValue: $this->tmpdir with non-falsable declared type 'string' cannot be assigned possibly false type 'false|string' (see https://psalm.dev/146)
|