Bump to phpstan level 8

simplesamlphp · Jan 24, 2025 · 09fc953 · 09fc953
1 parent 602fdcb
commit 09fc953
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/phpstan.neon b/phpstan.neon
@@ -1,6 +1,6 @@
 
 parameters:
-	level: 7
+	level: 8
 	paths:
 		- src
 	tmpDir: build/phpstan
diff --git a/src/Federation/Factories/TrustChainFactory.php b/src/Federation/Factories/TrustChainFactory.php
@@ -5,6 +5,7 @@
 namespace SimpleSAML\OpenID\Federation\Factories;
 
 use SimpleSAML\OpenID\Decorators\DateIntervalDecorator;
+use SimpleSAML\OpenID\Exceptions\TrustChainException;
 use SimpleSAML\OpenID\Federation\EntityStatement;
 use SimpleSAML\OpenID\Federation\MetadataPolicyApplicator;
 use SimpleSAML\OpenID\Federation\MetadataPolicyResolver;
@@ -35,6 +36,12 @@ public function empty(): TrustChain
      */
     public function fromStatements(EntityStatement ...$statements): TrustChain
     {
+        if (count($statements) < 3) {
+            throw new TrustChainException(
+                sprintf('TrustChain must have at least 3 statements, %s given.', count($statements)),
+            );
+        }
+
         $trustChain = $this->empty();
 
         // First item should be the leaf configuration.
@@ -46,7 +53,10 @@ public function fromStatements(EntityStatement ...$statements): TrustChain
         }
 
         // Last item should be trust anchor configuration.
-        $trustChain->addTrustAnchor(array_shift($statements));
+        ($trustAnchorStatement = array_shift($statements)) || throw new TrustChainException(
+            'No Trust Anchor statement present.',
+        );
+        $trustChain->addTrustAnchor($trustAnchorStatement);
 
         return $trustChain;
     }