CalibratedSensor: Allow saving of lut at runtime #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schnilz
changed the title
Before this change you needed to recompile the code with the calibration data. This change allows you to write code that saves the data to non volatile storage and load on the next power cycle
|
Thank you very much for contributing this! It looks like cool functionality that we should add... A couple of points:
|
|
Sry, I pushed the AbsIncSensor stuff to the wrong remote 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I continued with my little project and refactored the CalibrationSensor for more flexibility 😃
The current API does not expose the LUT so you cant save it on runtime and need to recompile the code for every motor with its specific calibration data. This change allows you to write code that saves the data to non volatile storage (like EEPROM and ESP32 flash NVS) and load on the next power cycle.
also fixes #17