Skip to content

Feat hybridstepper to main #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

askuric
Copy link
Member

@askuric askuric commented Mar 12, 2025

Provided that we move the HybridStepperClass to main this class in the drivers can either be removed or renamed. Here I've renamed it to HybridStepperMotorOld - it is not 100% the same as the one in the PR simplefoc/Arduino-FOC#457.
As it does not implement the current sensing and still has the issue with the space vector calculation explained here: https://community.simplefoc.com/t/driving-two-phase-bilpolar-steppers-with-three-phase-bldc-driver-hybrid-stepper-motor/5043

@runger1101001
Copy link
Member

We should merge the other PR first as this one also includes those changes from the calibrated sensor.

If the HybridStepper moves to main library, then I guess it’s better to remove it completely here.

@runger1101001
Copy link
Member

Hmm even after merging the other PR this one still shows all the same changes… whereas I think we want only the last commit from this PR, actually.

If it’s ok I’ll just make a new commit where I remove the old HybridStepper - I’ll leave the folder and point to the new functionality in its ReadMe

@askuric
Copy link
Member Author

askuric commented Mar 12, 2025

Yeah sure, go for it, I'm in for removing it.
I'm not sure why there are still some differences. There should not be any really. I'll look into it late.

@askuric askuric changed the base branch from dev to feat_stepper_calib March 12, 2025 16:37
@askuric askuric changed the base branch from feat_stepper_calib to dev March 12, 2025 16:37
@askuric
Copy link
Member Author

askuric commented Mar 12, 2025

Ok I've rebased it and it is ok now.

So yeah, if you want you can also just remove it and discard this PR.

@runger1101001 runger1101001 merged commit 05f458e into dev Mar 12, 2025
20 checks passed
@runger1101001
Copy link
Member

I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants