seq: Switch from type to scan_type

[mmccrackan]

LAT schedule errored out when passing in scan_type instead of the to-be depreciated type argument, since it defaults to type=1 if not passed. Switched to using scan_type instead.

[BrianJKoopman]

This change looks good, since type is being replaced, but I'm not sure I follow the error that occurred, because type defaults to None in the agent.

[mmccrackan]

This change looks good, since type is being replaced, but I'm not sure I follow the error that occurred, because type defaults to None in the agent.

I think it occurred because scheduler was changed to pass in scan_type without passing in type. Sorunlib has type default to 1, so it is always passed and is not None (

sorunlib/src/sorunlib/seq.py

Line 96 in e4305e0

type=type,

).

On this line in socs (https://github.com/simonsobs/socs/blob/194cc220036d4f8f41296a39e33bd13cf255c257/socs/agents/acu/agent.py#L2137), if type is not None, scan_type is replaced with type, so even though scan_type was being passed as 3, it was overwritten with 1.

[BrianJKoopman]

Ah, that makes sense, thanks for the explanation.