Skip to content

Fix additionalProperties default value in JTD validator #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
simbo1905 merged 8 commits into from
Sep 28, 2025
Merged

Fix additionalProperties default value in JTD validator #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
52ec5e7
Issue #89 Fix int32 type validation to reject decimal values like 3.14
simbo1905 Sep 27, 2025
bd738cb
Issue #89 Update CI test count to 461 after adding int32 decimal vali…
simbo1905 Sep 27, 2025
411fef7
Issue #89 Update CI test count to 463 after adding integer validation…
simbo1905 Sep 27, 2025
d4fd468
Issue #89 Update CI test count to 463 after adding integer validation…
simbo1905 Sep 27, 2025
cf16f71
Issue #91 Fix additionalProperties default value in JTD validator
simbo1905 Sep 27, 2025
60735a7
merge
simbo1905 Sep 28, 2025
bc1ae9d
Remove JtdExhaustiveTest from PR to allow merging bug fix
simbo1905 Sep 28, 2025
667fe3e
464
simbo1905 Sep 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ jobs:
for k in totals: totals[k]+=int(r.get(k,'0'))
except Exception:
pass
exp_tests=463
exp_tests=464
exp_skipped=0
if totals['tests']!=exp_tests or totals['skipped']!=exp_skipped:
print(f"Unexpected test totals: {totals} != expected tests={exp_tests}, skipped={exp_skipped}")
Expand Down
4 changes: 2 additions & 2 deletions json-java21-jtd/src/main/java/json/java21/jtd/Jtd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,8 +442,8 @@ JtdSchema compilePropertiesSchema(JsonObject obj) {
}
additionalProperties = bool.value();
} else if (properties.isEmpty() && optionalProperties.isEmpty()) {
// Empty schema with no properties defined allows additional properties by default
additionalProperties = true;
// Empty schema with no properties defined rejects additional properties by default
additionalProperties = false;
}

return new JtdSchema.PropertiesSchema(properties, optionalProperties, additionalProperties);
Expand Down
Loading