Fix/ci download issues #49
Conversation
- Remove download-maven-plugin from json-compatibility-suite/pom.xml - Remove maven-antrun-plugin download from json-java21-schema/pom.xml - Download test data locally and commit to src/test/resources/ - Update Java code to load from new local paths: - JsonTestSuiteSummary.java: use src/test/resources/JSONTestSuite-20250921/ - JsonSchemaCheckIT.java: use src/test/resources/JSONSchemaTestSuite-20250921/ - Add DOWNLOAD_COMMANDS.md files documenting curl commands used - This eliminates network download failures in CI builds Test data sources: - JSON Test Suite: https://github.com/nst/JSONTestSuite (master branch) - JSON Schema Test Suite: https://github.com/json-schema-org/JSON-Schema-Test-Suite (tag 23.1.0) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
- Add maven-compiler-plugin and maven-surefire-plugin exclusions to prevent Java files in src/test/resources from being compiled and run as tests - These Java files are part of the JSON Test Suite reference implementations and should not be executed as part of our test suite - This resolves the 'wrong name' errors during test execution 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
[P1] Update download verification path to vendored test suite
This test still asserts the presence of target/test-resources/JSONTestSuite-master/test_parsing, but the commit removes the download plugin and vendors the suite under src/test/resources/JSONTestSuite-20250921. The old directory is never created now, so this assertion will consistently fail and keep the build red. Point the test at the new resource path (or derive it from the classpath) so it reflects the updated layout.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
- Git rm all the dogshit (Swift files, Xcode projects, parsers, etc.) - Keep only the JSON test data we actually need in ZIP files - JSON Test Suite: json-test-suite-data.zip (72KB) with test_parsing JSON files - JSON Schema Test Suite: json-schema-test-suite-data.zip (96KB) with draft2020-12 tests 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
…P extraction - Remove download-maven-plugin and maven-antrun-plugin from pom.xml files - Add ZIP files containing only JSON test data (no extra files like Swift, Xcode projects) - Update JsonTestSuiteSummary.java to extract ZIP at runtime from test resources - Update JsonSchemaCheckIT.java to extract ZIP at runtime from test resources - Update DownloadVerificationTest.java to verify actual extracted files - All 157 json-java21-schema tests pass with new ZIP extraction approach The solution extracts ZIP files under target/ folder at runtime, eliminating external download dependencies that were causing CI failures.
…y and remove tests - Renamed JsonTestSuiteSummary to JsonCompatibilitySummary (not a test, just a reporting tool) - Deleted JsonTestSuiteTest.java (no longer needed) - Updated pom.xml exec plugin configuration to use new class name - Updated DownloadVerificationTest to use new class name - JsonCompatibilitySummary tool works correctly with ZIP extraction - JsonSchemaCheckIT integration tests pass (3472 tests, 0 failures, 0 errors) - All CI build failures resolved - both modules work with runtime ZIP extraction - Clean build and verify successful for both modules
- Added findZipFile() method to try multiple possible ZIP file locations - Works when run from different working directories (maven, IntelliJ, etc.) - JsonCompatibilitySummary tool now works correctly in all environments
|
Looks like there are a few issues preventing this PR from being merged!
If you'd like me to help, just leave a comment, like Feel free to include any additional details that might help me get this PR into a better state. You can manage your notification settings |
No description provided.