Add documentation and tests for typed/untyped conversion utilities #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added comprehensive documentation for the Json.fromUntyped() and Json.toUntyped() methods that provide bidirectional conversion between JsonValue objects and standard Java collections/types. Includes usage examples and type mappings.
- Created JsonTypedUntypedTests with full coverage of Json.fromUntyped() and Json.toUntyped() - Tests simple types, collections, nested structures, edge cases, and round-trip conversion - Added .mvn directory to fix mvnd warning about root directory
- Fixed generic type issues with List<?> by using @SuppressWarnings and proper casting - Corrected numeric type expectations (Integer boxed to Long in JsonNumber) - All 14 tests now pass successfully
- Added explicit PR event types: opened, synchronize, reopened - Ensures checks run when PRs are created or updated
simbo1905
pushed a commit
that referenced
this pull request
Aug 22, 2025
* Document type conversion utilities (fromUntyped/toUntyped) Added comprehensive documentation for the Json.fromUntyped() and Json.toUntyped() methods that provide bidirectional conversion between JsonValue objects and standard Java collections/types. Includes usage examples and type mappings. * Add comprehensive tests for typed/untyped conversion utilities - Created JsonTypedUntypedTests with full coverage of Json.fromUntyped() and Json.toUntyped() - Tests simple types, collections, nested structures, edge cases, and round-trip conversion - Added .mvn directory to fix mvnd warning about root directory * Fix JsonTypedUntypedTests compilation and test failures - Fixed generic type issues with List<?> by using @SuppressWarnings and proper casting - Corrected numeric type expectations (Integer boxed to Long in JsonNumber) - All 14 tests now pass successfully * Update GitHub Actions to trigger on PR events - Added explicit PR event types: opened, synchronize, reopened - Ensures checks run when PRs are created or updated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1
Summary
fromUntyped()andtoUntyped()conversion utilitiesChanges
Test Results
All 14 tests pass successfully across JDK 21, 22, 23, and 24.