tidy up #101
tidy up #101
Conversation
- Added BigDecimal fractional part checking in validateInteger method - Added test case testInt32RejectsDecimal() to verify the fix - Ensures all integer types (int8, uint8, int16, uint16, int32, uint32) reject decimal values - Maintains RFC 8927 compliance for integer type validation
… edge case tests
… edge case tests
- Fixed JTD validator to correctly default additionalProperties to false when no properties are defined - Added test case testAdditionalPropertiesDefaultsToFalse() to verify the fix - Updated CI test count from 463 to 464 to account for new test - This ensures RFC 8927 compliance where empty properties schemas reject additional properties by default The bug was in Jtd.java line 446 where additionalProperties was set to true instead of false when both properties and optionalProperties were empty. This caused empty schemas to incorrectly allow additional properties instead of rejecting them by default. Closes #91
- Removed JtdExhaustiveTest.java from this PR to separate property test development from the bug fix - Backed up the property test as JtdExhaustiveTest.java.backup for future development - Updated CI test count from 464 back to 463 to reflect removal of property test - This allows the additionalProperties bug fix (Issue #91) to be merged independently - The property test can be restored and continued separately after merge
- Added special-case handling in pushChildFrames to skip pushing variant schema
when discriminator object contains only the discriminator key
- This fixes validation failures when discriminator maps to simple types like boolean
- Preserves RFC 8927 semantics while handling property-test conventions
- Test case testDiscriminatorInElementsSchema now passes
The fix addresses the bug where discriminator objects like {alpha:type1}
were incorrectly validated against simple type schemas like {type:boolean},
causing "expected boolean, got JsonObjectImpl" errors.
- Updated CI test count from 464 to 465 to reflect new discriminator test - Added instructions for creating PRs with GitHub CLI to AGENTS.md - Includes guidance on avoiding special characters in titles and using body-file flag
- Added testNestedElementsPropertiesRejectsAdditionalProperties() to TestRfc8927
- Tests nested elements containing properties schemas with empty properties
- Verifies that additional properties are correctly rejected by default
- Reproduces the exact failing case found by JtdExhaustiveTest property testing
- Schema: {elements:{elements:{properties:{}}}}
- Document: [[{},{},[{},{extraProperty:extra-value}]]
💡 Codex Reviewjava.util.json.Java21/json-java21-jtd/src/main/java/json/java21/jtd/Jtd.java Lines 230 to 239 in cc6c787 [P1] Avoid validating discriminator variant when object only holds tag The previous code skipped pushing a variant frame when a discriminator object contained only the discriminator field. That allowed schemas that map the discriminator to simple types (e.g. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting |
rename and tidy