Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT Fix unit test #11585

Merged
merged 1 commit into from
Jan 29, 2025
Merged

MNT Fix unit test #11585

merged 1 commit into from
Jan 29, 2025

Conversation

emteknetnz
Copy link
Member

@emteknetnz emteknetnz mentioned this pull request Jan 29, 2025
Closed
@emteknetnz emteknetnz marked this pull request as ready for review January 29, 2025 21:29
GuySartorelli
GuySartorelli approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the failed unit test in the future - but for this one I know why it's failing so all good.
LGTM.

@GuySartorelli GuySartorelli merged commit c184016 into silverstripe:6.0 Jan 29, 2025
14 checks passed
@GuySartorelli GuySartorelli deleted the pulls/6.0/fix-unit-test branch January 29, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuySartorelli GuySartorelli GuySartorelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emteknetnz @GuySartorelli