API Deprecate FormField Value #11551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
emteknetnz
force-pushed
the
pulls/5/depr-ffv
branch
2 times, most recently
from
8bcc796 to
825cf40
Compare
GuySartorelli
requested changes
Jan 27, 2025
emteknetnz
force-pushed
the
pulls/5/depr-ffv
branch
2 times, most recently
from
075eb8f to
be6374a
Compare
emteknetnz
commented
Jan 27, 2025
GuySartorelli
requested changes
Jan 29, 2025
There was a problem hiding this comment.
If we're telling people to use the new methods instead, we need to also implement them in all the places that currently override Value() so that they get the correct value when calling methods on those classes.
The easier way would be to reverse your implementation so that getFormattedValue() for now calls return $this->Value(); which means overridden versions of Value() also apply that overridden value when calling getFormattedValue().
I'd do the latter personally as it's a lot less work and less prone to have unexpected regressions.
emteknetnz
force-pushed
the
pulls/5/depr-ffv
branch
2 times, most recently
from
db88a5f to
7e88a6d
Compare
|
Spoke offline and agreed to remove the aliases and reverted the deprecation message to how it was. |
emteknetnz
force-pushed
the
pulls/5/depr-ffv
branch
from
7e88a6d to
06b7a8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #11468