FIX Handle 401 from server #1906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emteknetnz
force-pushed
the
pulls/3.0/sudo-401
branch
from
7d27fa5 to
e2b3044
Compare
emteknetnz
commented
Feb 24, 2025
| doReject = undefined; | ||
| }); | ||
|
|
||
| function createJsonError(message) { |
There was a problem hiding this comment.
emteknetnz
force-pushed
the
pulls/3.0/sudo-401
branch
from
e2b3044 to
e9bf1a5
Compare
Comment on lines
+57
to
+59
| if (responseJson.result) { | ||
| onSuccess(); | ||
| } |
There was a problem hiding this comment.
What is the condition where this is false? Is that some sort of uncaught error?
|
Can you please check if the failing behat is relevant? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue silverstripe/.github#368
Requires silverstripe/silverstripe-frameworktest#228
Fixes https://github.com/silverstripe/silverstripe-admin/actions/runs/13491490322/job/37690345812#step:12:163
tests/behat/features/form-sudo-mode.feature:61
CMS 6 controller endpoints now returns a 401 instead of a 200 2...3#diff-038d2edcd2449c0dc4bf092c2aae85c43ee7c6300769e194d98787aacc70a178R92