DOC Document new filter by range functionality #687
Conversation
| @@ -25,6 +25,7 @@ use SilverStripe\ORM\DataObject; | |||
|
|
|||
| class MyDataObject extends DataObject | |||
| { | |||
| // ... | |||
There was a problem hiding this comment.
Adding these where appropriate in this file to indicate we're skipping some best practices for the sake of brevity - we tend to do this with new code blocks, so this just gives consistency across this file.
| 'ProductCode' => NumericField::class, | ||
| 'ProductCode' => [ | ||
| 'field' => NumericField::class, | ||
| ], |
There was a problem hiding this comment.
I don't know if this worked at some stage and broke, but it definitely doesn't work right now and shouldn't be documented as a thing that works.
| > If you don't specify a `FormField`, you must use the name of a real database field as the array key instead of a custom name so that a default field class can be determined. | ||
| > If you don't specify `field` or `dataType`, you must use the name of a real database field as the array key instead of a custom name so that a default field class can be determined. |
There was a problem hiding this comment.
dataType is new and was intended for use with the range stuff, but it also works here so makes sense to document this option.
en/08_Changelogs/6.0.0.md
Outdated
| @@ -596,6 +597,40 @@ SilverStripe\UserForms\Model\UserDefinedForm: | |||
|
|
|||
| </details> | |||
|
|
|||
| ### Filter within a range with `searchable_fields` {#searchable-withinrange} | |||
|
|
|||
| Using the `searchable_fields` configuration, you can now declare that a field should be filtered using a range. This works out of the box with the numeric, date, datetime, and time fields that come in Silverstripe framework. | |||
There was a problem hiding this comment.
| Using the `searchable_fields` configuration, you can now declare that a field should be filtered using a range. This works out of the box with the numeric, date, datetime, and time fields that come in Silverstripe framework. | |
| Using the `searchable_fields` configuration, you can now declare that a field should be filtered using a range. This works out of the box with the numeric, date, datetime, and time fields that come in the Silverstripe framework. |
| { | ||
| // ... | ||
| private static array $db = [ | ||
| 'Price' => 'Currency', |
There was a problem hiding this comment.
The currency filter currently seems very busted, even with the framework PR. There is a card open to fix at least some of that issues there, though the PR change this example use an Int instead so when people copy it they don't think that they've done something wrong
There was a problem hiding this comment.
I'd rather just fix the field. If it's just the validation thing, I'll pull that card into in progress and fix it. If there are more problems, please open cards for them.
There was a problem hiding this comment.
Noted on silverstripe/silverstripe-framework#11602 (comment) it's related to the framework PR, so should be fixed there
GuySartorelli
force-pushed
the
pulls/6.0/withinrange-filter
branch
from
7d59002 to
a0e943c
Compare
Issue
CMSMain/HierarchyModelAdminsilverstripe-cms#2949