-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to node 20.12.2 #111
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,34 +5,54 @@ on: [ push, pull_request ] | |
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
outputs: | ||
nvmrc: ${{ steps.makeNodeVersionOutput.outputs.nvmrc }} | ||
steps: | ||
- | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
with: | ||
fetch-depth: 0 # Fetch all history | ||
- | ||
uses: actions/setup-node@v3 | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version-file: '.nvmrc' | ||
- run: npm i -g [email protected] | ||
- | ||
name: PUT NVM version in output | ||
id: makeNodeVersionOutput | ||
run: echo "nvmrc=$(cat .nvmrc)" >> "$GITHUB_OUTPUT" | ||
|
||
- run: npm ci | ||
- run: npm run check-node-version | ||
- run: npm run standards | ||
- run: npm run build | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this missing the "Check for uncommitted changes" on purpose? |
||
test: | ||
needs: [ build ] | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
node-version: [ 14, 16, 'lts/*', 'latest' ] | ||
node-version: [ 16,'${{ needs.build.outputs.nvmrc }}', 'lts/*', 'latest' ] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Whitespace issue after the first comma |
||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
- | ||
name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v3 | ||
uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm i -g [email protected] | ||
- run: npm ci # Reinstall the dependencies to ensure they install with the current version of node | ||
- run: npm test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we be running the following before
|
||
- name: Coveralls | ||
uses: coverallsapp/github-action@v1 | ||
- | ||
name: Coveralls | ||
uses: coverallsapp/github-action@v2 | ||
with: | ||
parallel: true | ||
flag-name: ${{ matrix.node-version }} | ||
finish: | ||
needs: [ test ] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- | ||
name: Close parallel build | ||
uses: coverallsapp/github-action@v2 | ||
with: | ||
parallel-finished: true |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
16.15.0 | ||
20.12.2 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe we are standardizing on including the |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -91,9 +91,9 @@ module.exports = function(grunt) { | |
banner: '/*! <%= pkg.name %> <%= grunt.template.today("yyyy-mm-dd") %> <%= versionInfo %> */\n', | ||
sourceMap: true, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I believe we also usually use DEBUG on this line and the following |
||
sourceMapIncludeSources: true, | ||
mangle: true, | ||
compress: true, | ||
beautify: false, | ||
mangle: !DEBUG, | ||
compress: !DEBUG, | ||
beautify: DEBUG, | ||
}, | ||
}, | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this new line intended?