chore: upgrade Typescript to 5.7.2 and @types/node to 20.12.2 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahtylerb
force-pushed
the
jbrupbacher/upgrade-typescript
branch
2 times, most recently
from
9627c53 to
0e7e438
Compare
jonahtylerb
changed the title
onebytegone
requested changes
Jan 1, 2025
src/utils/delay.ts
Outdated
| @@ -1,4 +1,4 @@ | |||
| export function delay<T = undefined>(ms: number, value?: T): Promise<T> { | |||
| export function delay(ms: number, value?: undefined): Promise<undefined> { | |||
There was a problem hiding this comment.
Removing the generic will break usages like:
const val: string = await delay(100, 'cat');Does something like this work? It keeps the internal API agnostic of the type of value but external consumers have the option to return a value and have the proper return type inferred.
Suggested change
| export function delay(ms: number, value?: undefined): Promise<undefined> { | |
| export function delay(ms: number): Promise<undefined>; | |
| export function delay<T>(ms: number, value: T): Promise<T>; | |
| export function delay<T>(ms: number, value?: T): Promise<T | undefined> { |
src/utils/is-enum-value.ts
Outdated
| @@ -2,7 +2,7 @@ | |||
| * Type guard to check to see if the given value is a valid value for the enum. | |||
| */ | |||
| export function isEnumValue<T>(enumType: T, value: unknown): value is T[keyof T] { | |||
| return (Object.keys(enumType) as Array<keyof T>) | |||
| return (Object.keys(enumType as {}) as Array<keyof T>) | |||
There was a problem hiding this comment.
as casts can be dangerous. As such, we avoid them if at all possible. Would adjusting the function signature to the following example remove the need for the cast?
export function isEnumValue<T extends object>(enumType: T, value: unknown): value is T[keyof T] {
tests/utils/delay.test.ts
Outdated
| @@ -4,7 +4,7 @@ import { delay, isPromiseLike } from '../../src'; | |||
| describe('delay', () => { | |||
|
|
|||
| it('delays before returning a value', async () => { | |||
| let after: string | null = null, | |||
| let after: string | undefined | null = null, | |||
There was a problem hiding this comment.
If the types for delay change, this may no longer be needed.
tests/utils/is-empty.test.ts
Outdated
| @@ -31,7 +31,7 @@ describe('isEmpty', () => { | |||
| expect(t.isEmpty(() => {})).to.strictlyEqual(true); | |||
|
|
|||
| // deleting all the keys from on object empties it | |||
| o = { a: true }; | |||
| o = { a: true } as { a?: boolean }; | |||
There was a problem hiding this comment.
Same note about as casting.
Suggested change
| o = { a: true } as { a?: boolean }; | |
| const o: { a?: boolean } = { a: true }; |
jonahtylerb
force-pushed
the
jbrupbacher/upgrade-typescript
branch
from
0e7e438 to
276b464
Compare
jonahtylerb
force-pushed
the
jbrupbacher/upgrade-typescript
branch
from
276b464 to
8b9058a
Compare
jonahtylerb
force-pushed
the
jbrupbacher/upgrade-typescript
branch
from
8b9058a to
fec0370
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.