fix: add micromark parser to markdownlint config #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusBaldi
force-pushed
the
MatheusBaldi/fix-indent-alignment-exception
branch
from
d96016d to
7f48937
Compare
MrMarCode
suggested changes
Nov 28, 2024
There was a problem hiding this comment.
Thanks for working through this upgrade. Your hard work is appreciated!
Note: I usually don't test my own suggestions thoroughly. So if you could always be sure to test changes before finishing up, even if they are based on suggestions, that would be appreciated as well!
MatheusBaldi
force-pushed
the
MatheusBaldi/fix-indent-alignment-exception
branch
from
7f48937 to
d4bc349
Compare
In markdownlint 0.36.0, the support for micromark returned. Adding it in the config object fixes the error described in [this issue](#7) The new micromark version changes some previously assumed parser behaviors. It causes some errors related to nested intentation in HTML snippets. Since currently there is no need to lint HTML, the tokens related to it are now ignored. Introduces a new test verification to prevent an error where tokens cause other text tokens to appear to be indented.
MatheusBaldi
force-pushed
the
MatheusBaldi/fix-indent-alignment-exception
branch
from
d4bc349 to
3f05e92
Compare
MrMarCode
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
markdownlint0.36.0, the support formicromarkreturned. Adding it in the config object fixes the error described in this issueThe new
micromarkversion changes some previously assumed parser behaviors. It causes some errors related to nested intentation in HTML snippets. Since currently there is no need to lint HTML, the tokens related to it are now ignored.Introduces a new test verification to prevent an error where
htmlTexttokens cause other text tokens to appear to be indented.