config: migrate typescript partial eslint rules #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatheusBaldi
changed the title
MrMarCode
suggested changes
Feb 13, 2025
| // Replace eslint space-infix-ops with equivalent typescript-eslint rule to support | ||
| // linting type definitions | ||
| 'space-infix-ops': 'off', | ||
| '@typescript-eslint/space-infix-ops': [ 'error' ], | ||
| '@stylistic/space-infix-ops': [ 'error' ], |
There was a problem hiding this comment.
Now that the stylistic rules support both TS and JS syntax, is space-infix-ops needed here since it will be enabled in base.js?
There was a problem hiding this comment.
That's something I wasn't able to decide for sure. If the project uses the entire eslint-config, or at least the base partial together with the typescript partial, then it would be redundant indeed. But, if only the typescript partial is used, then the project would lack this rule, in case it is not defined here. Historically, this rule wasn't present in this file, until recently, but because of this possibility of using only the typescript partial, I went for what seemed like the safest approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on:
#115
Description
Migrate possible typescript partial rules to stylistic.