Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: migrate to stylistic eslint rules without observed impact #118

Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
e5638b7
config: migrate dot-location to stylistic
MatheusBaldi Feb 11, 2025
8bffae6
config: migrate no-floating-decimal to stylistic
MatheusBaldi Feb 11, 2025
e53dcd8
config: migrate wrap-iife to stylistic
MatheusBaldi Feb 11, 2025
dc210a0
config: migrate array-bracket-spacing to stylistic
MatheusBaldi Feb 11, 2025
098e710
config: migrate comma-spacing to stylistic
MatheusBaldi Feb 11, 2025
fe3da44
config: migrate comma-style to stylistic
MatheusBaldi Feb 11, 2025
d79f0a2
config: migrate computed-property-spacing to stylistic
MatheusBaldi Feb 11, 2025
3af4c9a
config: migrate eol-last to stylistic
MatheusBaldi Feb 11, 2025
2c1bcc0
config: migrate key-spacing to stylistic
MatheusBaldi Feb 11, 2025
540738d
config: migrate keyword-spacing to stylistic
MatheusBaldi Feb 11, 2025
f18e1ce
config: migrate linebreak-style to stylistic
MatheusBaldi Feb 11, 2025
ccc7223
config: migrate lines-around-comment to stylistic
MatheusBaldi Feb 11, 2025
7570fe6
config: migrate spaced-comment to stylistic
MatheusBaldi Feb 11, 2025
c46e697
config: migrate new-parens to stylistic
MatheusBaldi Feb 11, 2025
225e454
config: migrate no-multiple-empty-lines to stylistic
MatheusBaldi Feb 11, 2025
0c430ed
config: migrate func-call-spacing to stylistic
MatheusBaldi Feb 11, 2025
12d52b4
config: migrate no-trailing-spaces to stylistic
MatheusBaldi Feb 11, 2025
cca697d
config: migrate no-whitespace-before-property to stylistic
MatheusBaldi Feb 11, 2025
543757f
config: migrate one-var-declaration-per-line to stylistic
MatheusBaldi Feb 11, 2025
0b6d8c3
config: migrate quotes to stylistic
MatheusBaldi Feb 11, 2025
39c2288
config: migrate semi-spacing to stylistic
MatheusBaldi Feb 11, 2025
0ed79d0
config: migrate space-before-blocks to stylistic
MatheusBaldi Feb 11, 2025
c6c207b
config: migrate space-before-function-paren to stylistic
MatheusBaldi Feb 11, 2025
5ffbd41
config: migrate space-in-parens to stylistic
MatheusBaldi Feb 11, 2025
e7a439c
config: migrate space-unary-ops to stylistic
MatheusBaldi Feb 11, 2025
a18764a
config: migrate arrow-spacing to stylistic
MatheusBaldi Feb 11, 2025
f88766b
config: migrate arrow-parens to stylistic
MatheusBaldi Feb 11, 2025
5a53965
config: migrate template-curly-spacing to stylistic
MatheusBaldi Feb 11, 2025
48527fe
config: migrate object-property-newline to stylistic
MatheusBaldi Feb 11, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions partials/base.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module.exports = {
'curly': 'error',
'default-case': 'error',
'default-param-last': 'error',
'dot-location': [ 'error', 'property' ],
'@stylistic/dot-location': [ 'error', 'property' ],
'dot-notation': [
'error',
{ 'allowPattern': '^[a-z]+(_[a-z]+)+$' }, // Allow obj['snake_case']
Expand All @@ -66,7 +66,7 @@ module.exports = {
'no-extra-bind': 'error',
'no-extra-label': 'error',
'no-fallthrough': 'error',
'no-floating-decimal': 'error',
'@stylistic/no-floating-decimal': 'error',
'no-implicit-coercion': [ 'error', { 'allow': [ '!!' ] } ],
'no-implicit-globals': [ 'error', { 'lexicalBindings': true } ],
'no-implied-eval': 'error',
Expand Down Expand Up @@ -99,7 +99,7 @@ module.exports = {
'no-with': 'error',
'radix': 'error',
'vars-on-top': 'error',
'wrap-iife': 'error',
'@stylistic/wrap-iife': 'error',
'yoda': 'error',
// because we are still on commonjs module
'strict': 'off',
Expand All @@ -120,26 +120,26 @@ module.exports = {
'no-process-env': 'error',
'no-process-exit': 'error',
'no-sync': 'error',
'array-bracket-spacing': [ 'error', 'always' ],
'@stylistic/array-bracket-spacing': [ 'error', 'always' ],
'block-spacing': 'error',
'camelcase': 'error',
'comma-spacing': 'error',
'comma-style': 'error',
'computed-property-spacing': 'error',
'@stylistic/comma-spacing': 'error',
'@stylistic/comma-style': 'error',
'@stylistic/computed-property-spacing': 'error',
'consistent-this': [ 'error', 'self' ],
'eol-last': 'error',
'key-spacing': 'error',
'keyword-spacing': [
'@stylistic/eol-last': 'error',
'@stylistic/key-spacing': 'error',
'@stylistic/keyword-spacing': [
'error',
{
'overrides': {
'catch': { 'after': false },
},
},
],
'linebreak-style': [ 'error', 'unix' ],
'lines-around-comment': 'error',
'spaced-comment': [ 'error', 'always' ],
'@stylistic/linebreak-style': [ 'error', 'unix' ],
'@stylistic/lines-around-comment': 'error',
'@stylistic/spaced-comment': [ 'error', 'always' ],
'max-depth': [ 'error', 4 ],
'max-len': [
'error',
Expand All @@ -157,7 +157,7 @@ module.exports = {
'error',
{ 'capIsNewExceptions': [ 'Q' ] },
],
'new-parens': 'error',
'@stylistic/new-parens': 'error',
'padding-line-between-statements': [
'error',
{ blankLine: 'always', prev: [ 'var', 'let', 'const' ], next: '*' },
Expand All @@ -168,7 +168,7 @@ module.exports = {
'no-import-assign': 'error',
'no-dupe-else-if': 'error',
'no-lonely-if': 'error',
'no-multiple-empty-lines': [
'@stylistic/no-multiple-empty-lines': [
'error',
{
'max': 2,
Expand All @@ -193,33 +193,33 @@ module.exports = {
'YieldExpression',
],
'no-setter-return': 'error',
'func-call-spacing': 'error',
'no-trailing-spaces': 'error',
'@stylistic/func-call-spacing': 'error',
'@stylistic/no-trailing-spaces': 'error',
'no-unneeded-ternary': 'error',
'no-whitespace-before-property': 'error',
'@stylistic/no-whitespace-before-property': 'error',
'object-curly-spacing': [ 'error', 'always' ],
'one-var': [ 'error', { 'var': 'always', 'let': 'consecutive' } ],
'one-var-declaration-per-line': 'error',
'quotes': [ 'error', 'single' ],
'@stylistic/one-var-declaration-per-line': 'error',
'@stylistic/quotes': [ 'error', 'single' ],
'semi': [ 'error', 'always' ],
'semi-spacing': 'error',
'space-before-blocks': 'error',
'space-before-function-paren': [
'@stylistic/semi-spacing': 'error',
'@stylistic/space-before-blocks': 'error',
'@stylistic/space-before-function-paren': [
'error',
{
'anonymous': 'never',
'named': 'never',
'asyncArrow': 'always',
},
],
'space-in-parens': [ 'error', 'never' ],
'@stylistic/space-in-parens': [ 'error', 'never' ],
'space-infix-ops': 'error',
'space-unary-ops': 'error',
'@stylistic/space-unary-ops': 'error',
'unicode-bom': 'error',
'arrow-body-style': [ 'error', 'always' ],
'arrow-spacing': [ 'error', { 'before': true, 'after': true } ],
'arrow-parens': 'error',
'template-curly-spacing': [ 'error', 'never' ],
'object-property-newline': [ 'error', { 'allowAllPropertiesOnSameLine': true } ],
'@stylistic/arrow-spacing': [ 'error', { 'before': true, 'after': true } ],
'@stylistic/arrow-parens': 'error',
'@stylistic/template-curly-spacing': [ 'error', 'never' ],
'@stylistic/object-property-newline': [ 'error', { 'allowAllPropertiesOnSameLine': true } ],
},
};