Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config: migrate comma-dangle to stylistic #114

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MatheusBaldi
Copy link
Contributor

@MatheusBaldi MatheusBaldi commented Feb 7, 2025

Depends on:

#111
#115

Details

We majorly allow the last element of an enum to have a trailing comma, so, for that reason, this PR specifically defines this as one our rule behaviors. This rule was not enforced for ts syntax, so now that it is, some little changes are needed in the projects that use it

Copy link

@MrMarCode MrMarCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the rule be moved back to the same spot as discussed here please?

@MatheusBaldi MatheusBaldi force-pushed the MatheusBaldi/migrate-comma-dangle-to-stylistic branch from c88dff2 to 9c41f31 Compare February 13, 2025 12:41
@MatheusBaldi
Copy link
Contributor Author

Can the rule be moved back to the same spot as discussed here please?

@MrMarCode done

'error',
{
'arrays': 'always-multiline',
'objects': 'always-multiline',
'imports': 'always-multiline',
'exports': 'always-multiline',
'enums': 'always-multiline',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on feedback regarding the addition to this rule. Otherwise this LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants