Skip to content

Conversation

@pmachapman
Copy link
Collaborator

@pmachapman pmachapman commented Nov 20, 2025

This PR fixes a bug where the train on target filter's scripture ranges were blank, when they should have been the same as the source filter's scripture ranges.


This change is Reviewable

@pmachapman pmachapman added the will require testing PR should not be merged until testers confirm testing is complete label Nov 20, 2025
@codecov
Copy link

codecov bot commented Nov 20, 2025

Codecov Report

❌ Patch coverage is 84.61538% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.80%. Comparing base (142f019) to head (a4c22bf).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...XForge.Scripture/Services/MachineProjectService.cs 84.61% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3580      +/-   ##
==========================================
- Coverage   82.80%   82.80%   -0.01%     
==========================================
  Files         608      608              
  Lines       37201    37211      +10     
  Branches     6104     6106       +2     
==========================================
+ Hits        30803    30811       +8     
  Misses       5472     5472              
- Partials      926      928       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@RaymondLuong3 RaymondLuong3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so it looks like previously the trainOn target filters was blank which resulted in all of the books being used from the target project. This change ensures that only the selected target books are used for training. I reproduced the issue on master and can confirm the acceptance tests pass. Nice work!

@RaymondLuong3 reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pmachapman)

@RaymondLuong3 RaymondLuong3 self-assigned this Nov 20, 2025
@RaymondLuong3 RaymondLuong3 added ready to test and removed will require testing PR should not be merged until testers confirm testing is complete labels Nov 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants