Quotation denormalization#203

Open

benjaminking wants to merge 28 commits intomainfrom

quotation_denormalization

Commits on Jul 22, 2025

Some tests pass

johnml1135
authored and
Ben King
committed
Added more test framework

johnml1135
authored and
Ben King
committed
Basic implementation and tests for quote convention detection
Ben King
committed
Initial working version of quotation denormalization
Ben King
committed
I want to process the data in segments that correspond to individual translations. These updates make it happen.

johnml1135
authored and
Ben King
committed
Updates for reviewer comments

johnml1135
authored and
Ben King
committed
Respond to reviewer comments

johnml1135
authored and
Ben King
committed
Additional denormalization tests (not all passing)
Ben King
committed
Rebase + additional denormalization tests
Ben King
committed
Improved handling for NLLB-produced quote errors
Ben King
committed
Unit tests for basic quotation mark resolver
Ben King
committed
Unit tests for UsfmStructureExtractor
Ben King
committed
Unit tests for several quotation mark analysis classes
Ben King
committed
Fix a bug related to verse markers before quotation marks
Ben King
committed
Refactoring to allow arbitrary quote convention changes + more unit tests
Ben King
committed
Remaining unit tests
Ben King
committed
Change update_usfm_parser_handler.py to match main branch
Ben King
committed
Fix linting for test_quote_convention_detector.py
Ben King
committed
Address reviewer comments + refactor
Ben King
committed
Correct TextSegment equality function
Ben King
committed
Damien's requested code-review changes
Ben King
committed
Eli's requested code-review changes
Ben King
committed
One code review change that was left out of the previous commit
Ben King
committed
Fixes for Eli's hopefully final code review comments
Ben King
committed
Fix typing issue in tests for QuotationMarkUpdateFirstPass
Ben King
committed
Bug fix for multi-character quotation marks
Ben King
committed
Use is_at_start_of_segment for consistency
Ben King
committed
Include analysis details in QuoteConventionAnalysis
Ben King
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Quotation denormalization#203

Quotation denormalization#203
benjaminking wants to merge 28 commits intomainfrom
quotation_denormalization

Commits on Jul 22, 2025

Some tests pass

Added more test framework

Basic implementation and tests for quote convention detection

Initial working version of quotation denormalization

I want to process the data in segments that correspond to individual translations. These updates make it happen.

Updates for reviewer comments

Respond to reviewer comments

Additional denormalization tests (not all passing)

Rebase + additional denormalization tests

Improved handling for NLLB-produced quote errors

Unit tests for basic quotation mark resolver

Unit tests for UsfmStructureExtractor

Unit tests for several quotation mark analysis classes

Fix a bug related to verse markers before quotation marks

Refactoring to allow arbitrary quote convention changes + more unit tests

Remaining unit tests

Change update_usfm_parser_handler.py to match main branch

Fix linting for test_quote_convention_detector.py

Address reviewer comments + refactor

Correct TextSegment equality function

Damien's requested code-review changes

Eli's requested code-review changes

One code review change that was left out of the previous commit

Fixes for Eli's hopefully final code review comments

Fix typing issue in tests for QuotationMarkUpdateFirstPass

Bug fix for multi-character quotation marks

Use is_at_start_of_segment for consistency

Include analysis details in QuoteConventionAnalysis

Uh oh!

Quotation denormalization#203benjaminking wants to merge 28 commits intomainsillsdev/machine.py:mainfrom quotation_denormalizationsillsdev/machine.py:quotation_denormalizationCopy head branch name to clipboard

Commits

Commits on Jul 22, 2025

Quotation denormalization#203
benjaminking wants to merge 28 commits intomainfrom
quotation_denormalization