Skip to content

[CharInv] Preserve pre-find-and-replace status changes in goal history #4041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[CharInv] Preserve pre-find-and-replace status changes in goal history #4041

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a09cbc4
[CharInv] Preserve pre-find-replace status-change record
imnasnainaec Nov 24, 2025
3cc16dc
Create addCharChanges (like addWordChanges)
imnasnainaec Nov 24, 2025
470c839
Merge branch 'master' into char-inv-status-changes
imnasnainaec Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions src/goals/CharacterInventory/Redux/CharacterInventoryActions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,7 @@ export function uploadInventory() {
validCharacters: charInvState.validCharacters,
})
);
const changes = getState().goalsState.currentGoal.changes as CharInvChanges;
dispatch(addCharInvChangesToGoal({ ...changes, charChanges }));
await dispatch(asyncUpdateGoal());
await dispatch(addCharChanges(charChanges));
};
}

Expand Down Expand Up @@ -172,6 +170,20 @@ export function loadCharInvData() {
};
}

/** Returns a dispatch function to: in both frontend and backend, add to the current
* goal's changes new character inventory status changes. */
function addCharChanges(charChanges: CharacterChange[]) {
return async (dispatch: StoreStateDispatch, getState: () => StoreState) => {
const changes: CharInvChanges = {
...defaultCharInvChanges,
...getState().goalsState.currentGoal.changes,
};
changes.charChanges = [...changes.charChanges, ...charChanges];
dispatch(addCharInvChangesToGoal(changes));
await dispatch(asyncUpdateGoal());
};
}

/** Returns a dispatch function to: in both frontend and backend, add to the current
* goal's changes the dictionary of words updated with the find-and-replace tool. */
function addWordChanges(wordChanges: FindAndReplaceChange) {
Expand Down
Loading