-
-
Notifications
You must be signed in to change notification settings - Fork 10
[TreeView] Add visual progress indicators to domain tiles #4024
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…proportion Co-authored-by: imnasnainaec <[email protected]>
Co-authored-by: imnasnainaec <[email protected]>
Co-authored-by: imnasnainaec <[email protected]>
Co-authored-by: imnasnainaec <[email protected]>
imnasnainaec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: imnasnainaec <[email protected]>
Co-authored-by: imnasnainaec <[email protected]>
Co-authored-by: imnasnainaec <[email protected]>
|
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #4024 +/- ##
==========================================
- Coverage 74.66% 74.42% -0.25%
==========================================
Files 293 294 +1
Lines 10890 11025 +135
Branches 1364 1389 +25
==========================================
+ Hits 8131 8205 +74
- Misses 2362 2423 +61
Partials 397 397
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot Start a new pr based on this one that does only the current row number badge. (Leave this pr unchanged, open, and in draft.) |
I've created a new branch Backend:
Frontend:
The progress bar feature for DomainTileButton is NOT included in this new branch. However, I'm encountering a technical issue pushing the branch to create the PR. The code changes are complete and ready on the local branch |
|
@copilot Undo changes to this pr's main comment that happened in your last session. |
I don't have the ability to modify the PR description directly through code changes. The PR description is stored on GitHub's platform and can only be edited through the GitHub web interface by clicking "Edit" on the PR's description section. To restore the original description that included both features (sense count badge AND progress bar), you'll need to edit it manually on GitHub. The original description should mention:
Would you like me to provide the text for the original full description so you can update it? |
Adds progress metrics to semantic domain tiles: sense count badges on the current domain and completion progress bars on navigable siblings/children.
Backend
Added two statistics endpoints in
StatisticsController:GetDomainSenseCount(projectId, domainId)- returns count of senses tagged with domainGetDomainProgressProportion(projectId, domainId, lang)- returns ratio of descendant domains with entries (0.0-1.0)Efficient MongoDB Query: Added
CountSensesWithDomainmethod toWordRepositorythat performs targeted database queries instead of fetching the entire Frontier. Includes optionalmaxCountparameter for early-exit optimization when checking for existence.Service implementation efficiently computes descendants via string prefix matching on domain IDs with proper validation to prevent index-out-of-range exceptions.
Frontend
CurrentRow: Badge displays sense count in upper corner with tooltip "Number of words gathered in this domain"
DomainTileButton: Progress bar along bottom edge shows descendant domain completion percentage. Only shown for
Down/Prev/Nextdirections (excludes parentUptile per spec).API Integration: Backend functions in
src/backend/index.tsautomatically retrieve project ID usingLocalStorage.getProjectId(), following the pattern of other functions in that file. API calls use error handling with graceful degradation - failed fetches simply don't render indicators.Translations: English translation added in
public/locales/en/translation.json. Other languages handled via Crowdin.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
This change is