Fix ci #1135
Fix ci #1135
Conversation
WalkthroughThe changes in the Changes
Sequence Diagram(s)sequenceDiagram
participant CI as CI Workflow
participant Docker as Docker Container
participant Pip as Pip Installer
CI->>Docker: Uninstall transformer-engine
Docker->>Pip: Run pip install huggingface-hub==0.25.2
Pip-->>Docker: Installation complete
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
.github/workflows/examples.yml (1)
298-298: Document version requirement in requirements.txt.Consider adding the huggingface-hub version requirement to the appropriate requirements.txt file instead of installing it directly in the workflow. This would make the dependency requirement more visible and maintainable.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/examples.yml(1 hunks)
🔇 Additional comments (1)
.github/workflows/examples.yml (1)
298-298: LGTM! Verify huggingface-hub version requirement.
The addition of huggingface-hub installation looks good. However, let's verify if version 0.25.2 is specifically required.
✅ Verification successful
Version 0.25.2 is higher than required dependencies
Looking at the codebase:
- The requirements.txt in
onediff_comfy_nodes/docs/sd3/requirements.txtspecifies huggingface-hub==0.23.3 - No other version constraints found in setup files or other configuration files
- The codebase primarily uses huggingface-hub for downloading models and doesn't rely on version-specific features
Installing a newer version (0.25.2) than what's specified in requirements (0.23.3) should not cause compatibility issues, as huggingface-hub maintains backward compatibility.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Check if huggingface-hub version is mentioned in requirements files
# or if there are version constraints in other files.
echo "Checking requirements files for huggingface-hub version constraints..."
rg -l "huggingface-hub" | grep -i "requirements.txt"
echo "Checking for huggingface-hub imports and version checks in Python files..."
rg "from huggingface_hub" -A 3
Length of output: 1942
Script:
#!/bin/bash
# Check the content of the requirements file found and any other potential version constraints
echo "Checking content of found requirements file..."
cat onediff_comfy_nodes/docs/sd3/requirements.txt
echo -e "\nChecking for any version constraints in setup files..."
rg "huggingface-hub" -A 2 -B 2 setup.py setup.cfg pyproject.toml 2>/dev/null
echo -e "\nChecking ComfyUI related files for huggingface-hub usage..."
rg "huggingface" -A 2 -B 2 $(fd -t f . onediff_comfy_nodes)
Length of output: 22888
Summary by CodeRabbit
New Features
huggingface-hubpackage to enhance ComfyUI testing capabilities.Chores
Refactor
OneDiffControlLoraclass for improved operational behavior during the model's pre-run phase.