Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: quality of life optional values to leases-cleanup job and webhook deployment #894

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

falcorocks
Copy link
Contributor

@falcorocks falcorocks commented Jan 21, 2025

Description of the change

this PR adds the following optional values, which allows to easily follow Kubernetes best practices/provide more flexibility

  • leases cleanup job:
    • priorityClass
    • automountServiceAccountToken
    • podSecurityContext
    • resources
  • deployment webhook:
    • priorityClass
    • automountServiceAccountToken
    • envFrom

Existing or Associated Issue(s)

Additional Information

Proof of work

helm template . \
--set webhook.envFrom.configmaps={cm1} \
--set 'webhook.envFrom.secrets={secr1,secr2}' \
--set webhook.priorityClass=critical \
--set webhook.automountServiceAccountToken=true \
--set leasescleanup.priorityClass=critical \
--set leasescleanup.automountServiceAccountToken=false \
--set leasescleanup.podSecurityContext.enabled=false \
--set leasescleanup.podSecurityContext.runAsUser=12345 \
--set leasescleanup.resources.requests.memory=12345Mi \
--set leasescleanup.resources.limits.cpu=12345m \
| grep -C 3 'leases-cleanup\|deployment_webhook.yaml\|cm1\|secr1\|secr2\|critical\|automountServiceAccountToken\|12345'
Screenshot 2025-02-14 at 10 29 01

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@falcorocks falcorocks changed the title Feat best practices values feat: add some best practice values to leases-cleanup job & deployment Jan 21, 2025
@falcorocks falcorocks marked this pull request as draft January 21, 2025 13:45
@falcorocks falcorocks changed the title feat: add some best practice values to leases-cleanup job & deployment feat: add some best practice values to leases-cleanup job & webhook deployment Jan 21, 2025
@falcorocks falcorocks marked this pull request as ready for review January 21, 2025 13:54
@falcorocks falcorocks force-pushed the feat-best-practices-values branch 3 times, most recently from a846b3d to 3edf674 Compare January 21, 2025 14:11
@falcorocks falcorocks marked this pull request as draft January 21, 2025 14:14
@falcorocks falcorocks marked this pull request as ready for review January 21, 2025 15:39
@falcorocks falcorocks force-pushed the feat-best-practices-values branch 7 times, most recently from a5ca1bc to a8b34ab Compare January 23, 2025 16:20
@falcorocks falcorocks changed the title feat: add some best practice values to leases-cleanup job & webhook deployment add values to leases-cleanup job and webhook deployment & cleanup schema Jan 23, 2025
@falcorocks falcorocks force-pushed the feat-best-practices-values branch 2 times, most recently from 8231ffe to 2544b33 Compare January 23, 2025 16:46
Copy link
Contributor

@hectorj2f hectorj2f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, split the PR so it is easy to review both changes. Let's open a PR for the schema cleanup.

@falcorocks falcorocks changed the title add values to leases-cleanup job and webhook deployment & cleanup schema add values to leases-cleanup job and webhook deployment Feb 3, 2025
@falcorocks
Copy link
Contributor Author

Please, split the PR so it is easy to review both changes. Let's open a PR for the schema cleanup.

thank you @hectorj2f , I've moved the fix to the schema here #904. I'm changing this PR to draft until that is resolved.

@falcorocks falcorocks marked this pull request as draft February 13, 2025 15:08
@falcorocks falcorocks force-pushed the feat-best-practices-values branch 4 times, most recently from 152e646 to 6fe3866 Compare February 13, 2025 16:03
@falcorocks falcorocks closed this Feb 13, 2025
@falcorocks falcorocks force-pushed the feat-best-practices-values branch from 6fe3866 to 173e112 Compare February 13, 2025 16:16
@falcorocks falcorocks reopened this Feb 13, 2025
@falcorocks falcorocks changed the title add values to leases-cleanup job and webhook deployment add quality of life optional values to leases-cleanup job and webhook deployment Feb 13, 2025
@falcorocks falcorocks force-pushed the feat-best-practices-values branch 7 times, most recently from b09473f to 979f19c Compare February 14, 2025 09:27
@falcorocks falcorocks changed the title add quality of life optional values to leases-cleanup job and webhook deployment feat: quality of life optional values to leases-cleanup job and webhook deployment Feb 14, 2025
@falcorocks falcorocks marked this pull request as ready for review February 14, 2025 09:33
@falcorocks falcorocks force-pushed the feat-best-practices-values branch 3 times, most recently from 4ad4abb to dceb782 Compare February 14, 2025 09:49
@falcorocks falcorocks force-pushed the feat-best-practices-values branch from dceb782 to 1e73c45 Compare February 14, 2025 09:50
@falcorocks falcorocks requested a review from hectorj2f February 14, 2025 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants