-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: quality of life optional values to leases-cleanup job and webhook deployment #894
base: main
Are you sure you want to change the base?
Conversation
a846b3d
to
3edf674
Compare
a5ca1bc
to
a8b34ab
Compare
8231ffe
to
2544b33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, split the PR so it is easy to review both changes. Let's open a PR for the schema cleanup.
thank you @hectorj2f , I've moved the fix to the schema here #904. I'm changing this PR to |
152e646
to
6fe3866
Compare
6fe3866
to
173e112
Compare
b09473f
to
979f19c
Compare
4ad4abb
to
dceb782
Compare
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
Signed-off-by: falcorocks <[email protected]>
dceb782
to
1e73c45
Compare
Description of the change
this PR adds the following optional values, which allows to easily follow Kubernetes best practices/provide more flexibility
priorityClass
automountServiceAccountToken
podSecurityContext
resources
priorityClass
automountServiceAccountToken
envFrom
Existing or Associated Issue(s)
Additional Information
Proof of work
Checklist
Chart.yaml
according to semver. Where applicable, update and bump the versions in any associated umbrella chartvalues.yaml
and added to the README.md. The helm-docs utility can be used to generate the necessary content. Usehelm-docs --dry-run
to preview the content.ct lint
command.