Skip to content

Commit

Permalink
fix: policy controller chart schema (#904)
Browse files Browse the repository at this point in the history
* ci: add workflow to validate schema

Signed-off-by: falcorocks <[email protected]>

* fix: policy controller chart schema

removes keys required and additonalProperties from the controller chart
schema that were added by mistake in 142e34b
see https://sigstore.slack.com/archives/C03096V09F1/p1737627750048369

Signed-off-by: falcorocks <[email protected]>

* Update .github/workflows/check-schema-policy-controller.yml

Co-authored-by: Bob Callaway <[email protected]>
Signed-off-by: falcorocks <[email protected]>

* ci: remove go version from setup-go step

Signed-off-by: falcorocks <[email protected]>

* ci: pin version of setup-go action to v5.3.0 digest (latest)

Signed-off-by: falcorocks <[email protected]>

---------

Signed-off-by: falcorocks <[email protected]>
Co-authored-by: Bob Callaway <[email protected]>
  • Loading branch information
falcorocks and bobcallaway authored Feb 13, 2025
1 parent 173e112 commit 7ff2fe4
Show file tree
Hide file tree
Showing 4 changed files with 61 additions and 167 deletions.
40 changes: 40 additions & 0 deletions .github/workflows/check-schema-policy-controller.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: Check Helm Schema (policy-controller only)

on:
pull_request:
paths:
- "charts/policy-controller/**"

jobs:
schema:
runs-on: ubuntu-latest

steps:
- name: Checkout repository
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
- name: setup go
uses: actions/setup-go@f111f3307d8850f501ac008e886eec1fd1932a34 # v5.3.0

- name: install helm-schema
run: go install github.com/dadav/helm-schema/cmd/helm-schema@latest

- name: test helm-schema
run: helm-schema --version

- name: Run Helm Schema and check the outcome
run: |
cd charts/policy-controller && helm-schema -k additionalProperties,required
exit_code=$(git diff --exit-code)
exit ${exit_code}
- name: Print a comment in case of failure
run: |
echo "The policy controller values.schema.json is not up to date or has not been produced correctly
Please, install https://github.com/dadav/helm-schema
And run with flag -k additionalProperties,required before pushing
exit 1
if: |
failure() && github.event.pull_request.head.repo.full_name == github.repository
2 changes: 1 addition & 1 deletion charts/policy-controller/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ sources:
type: application

name: policy-controller
version: 0.9.0
version: 0.9.1
appVersion: 0.12.0

maintainers:
Expand Down
2 changes: 1 addition & 1 deletion charts/policy-controller/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

<!-- This README.md is generated. Please edit README.md.gotmpl -->

![Version: 0.9.0](https://img.shields.io/badge/Version-0.9.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.12.0](https://img.shields.io/badge/AppVersion-0.12.0-informational?style=flat-square)
![Version: 0.9.1](https://img.shields.io/badge/Version-0.9.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 0.12.0](https://img.shields.io/badge/AppVersion-0.12.0-informational?style=flat-square)

The Helm chart for Policy Controller

Expand Down
Loading

0 comments on commit 7ff2fe4

Please sign in to comment.