Prepare sensitive_url for crates.io
#8223
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macladson
added
code-quality
dependencies
macladson
commented
Oct 16, 2025
Comment on lines
-137
to
-138
| SensitiveUrl::parse(beacon_url.as_ref()) | ||
| .map_err(|e| format!("Failed to parse beacon http server: {:?}", e))?, |
There was a problem hiding this comment.
I'm not sure why we were re-parsing beacon_url since it's already a SensitiveUrl so I think we can just clone here instead.
|
Some required checks have failed. Could you please take a look @macladson? 🙏 |
mergify
bot
added
waiting-on-author
macladson
added
ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Another good candidate for publishing separately from Lighthouse is
sensitive_urlas it's a general utility crate and not related to Ethereum. This PR prepares it to be spun out into its own crate.Proposed Changes
I've made the
fullfield onSensitiveUrlprivate and instead provided an explicit getter called.expose_full(). It's a bit ugly for the diff but I prefer the explicit nature of the getter.I've also added some extra tests and doc strings along with feature gating
SerializeandDeserializeimplementations behind theserdefeature.Additional Info
I also removed
AsRef<str>as this was previously used quite awkwardly and instead I've implemented a.redacted()getter which I think is cleaner.