deduplicate types and redundant impls #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks this was on my todo list. lgtm |
Zacholme7
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While implementing network message passing, I noticed that we have a bunch of duplicated code - mainly
network::types::ssv_messageandssv_types::message.There were also some remnants of parallel development (and the attempted independence of
qbft):MessageIDvsMessageIdvsMsgIdandOperatorIdvsOperatorID.I now aligned those. Reasoning behind
IdoverIDis that it isn't an acronym, but short forIdentifier.Last, but not least: We had many locations where we manually implemented
EncodeandDecode- I changed this use the derive macro instead.I do not claim that this PR is complete, there may be a few more places to optimize.