add back qbft_message validation

sigp · Feb 26, 2025 · ca76591 · ca76591
1 parent e09372d
commit ca76591
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/anchor/common/qbft/src/lib.rs b/anchor/common/qbft/src/lib.rs
@@ -214,6 +214,12 @@ where
         &self,
         wrapped_msg: &WrappedQbftMessage,
     ) -> Option<(Option<ValidData<D>>, OperatorId)> {
+        // Validate the qbft message
+        if !wrapped_msg.qbft_message.validate() {
+            warn!("Invalid qbft_message");
+            return None;
+        }
+
         // Ensure that this message is for the correct round
         let current_round = self.current_round.get();
         if (wrapped_msg.qbft_message.round < current_round as u64)

diff --git a/anchor/common/ssv_types/src/consensus.rs b/anchor/common/ssv_types/src/consensus.rs
@@ -59,6 +59,16 @@ pub struct QbftMessage {
     pub prepare_justification: Vec<SignedSSVMessage>,      // always without full_data
 }
 
+impl QbftMessage {
+    /// Do QBFTMessage specific validation
+    pub fn validate(&self) -> bool {
+        if self.qbft_message_type > QbftMessageType::RoundChange {
+            return false;
+        }
+        true
+    }
+}
+
 /// Different states the QBFT Message may represent
 #[derive(Clone, Debug, PartialEq, PartialOrd, Copy)]
 pub enum QbftMessageType {