-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 2025-01-16 #1169
base: main
Are you sure you want to change the base?
Release 2025-01-16 #1169
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jpsantosbh, this might sound stupid since we still have not yet made this an automated process, but just wanted to highlight all the changelog.md needs minor changes.
- The project details should come at the start of the md file.
- The MAJOR, MINOR, and PATCH, should be changed into Added, Changed, and Fixed.
- The version title needs to follow this pattern:
[M.M.P] - YYYY-MM-DD
@@ -22,7 +22,7 @@ | |||
], | |||
"repository": { | |||
"type": "git", | |||
"url": "https://github.com/signalwire/signalwire-js" | |||
"url": "git+https://github.com/signalwire/signalwire-js.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be wrong, considering the repository URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm WARN publish npm auto-corrected some errors in your package.json when publishing. Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish "repository.url" was normalized to "git+https://github.com/signalwire/signalwire-js.git"
I had this error when I was publishing the release. then I just executed npm pkg fix
, and that change was introduced.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks! I did not know that.
|
||
- [#1123](https://github.com/signalwire/signalwire-js/pull/1123) [`76e573f46553337990c397693985e5004eeecae1`](https://github.com/signalwire/signalwire-js/commit/76e573f46553337990c397693985e5004eeecae1) Thanks [@iAmmar7](https://github.com/iAmmar7)! - CF SDK: Expose room layout on the `CallFabriRoomSession` object | ||
|
||
### Modified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### Modified | |
### Changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, can you please update this change in other changelog files as well?
@@ -22,7 +22,7 @@ | |||
], | |||
"repository": { | |||
"type": "git", | |||
"url": "https://github.com/signalwire/signalwire-js" | |||
"url": "git+https://github.com/signalwire/signalwire-js.git" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks! I did not know that.
Also, can you fix the date in the PR title, please? |
Isn't the date the date when we publish to npm? |
True, we release to the NPM when we merge this PR. So, the date needs to change if we merge it tomorrow. |
@iAmmar7 But we did the release already. NPM will reject the new publish with the same version that is already there. so this date is already fine. |
Alright. @Devon-White, could you please prepare the release notes and update the docs if that's necessary. |
Description
Release SDKs
Type of change
Code snippets
In case of new feature or breaking changes, please include code snippets.