Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2025-01-16 #1169

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Release 2025-01-16 #1169

wants to merge 3 commits into from

Conversation

jpsantosbh
Copy link
Collaborator

Description

Release SDKs

Type of change

  • Internal refactoring
  • Bug fix (bugfix - non-breaking)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Code snippets

In case of new feature or breaking changes, please include code snippets.

Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 9a5a446

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Collaborator

@iAmmar7 iAmmar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jpsantosbh, this might sound stupid since we still have not yet made this an automated process, but just wanted to highlight all the changelog.md needs minor changes.

  1. The project details should come at the start of the md file.
  2. The MAJOR, MINOR, and PATCH, should be changed into Added, Changed, and Fixed.
  3. The version title needs to follow this pattern: [M.M.P] - YYYY-MM-DD

@@ -22,7 +22,7 @@
],
"repository": {
"type": "git",
"url": "https://github.com/signalwire/signalwire-js"
"url": "git+https://github.com/signalwire/signalwire-js.git"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be wrong, considering the repository URL.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm WARN publish npm auto-corrected some errors in your package.json when publishing.  Please run "npm pkg fix" to address these errors.
npm WARN publish errors corrected:
npm WARN publish "repository.url" was normalized to "git+https://github.com/signalwire/signalwire-js.git"

I had this error when I was publishing the release. then I just executed npm pkg fix, and that change was introduced.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks! I did not know that.


- [#1123](https://github.com/signalwire/signalwire-js/pull/1123) [`76e573f46553337990c397693985e5004eeecae1`](https://github.com/signalwire/signalwire-js/commit/76e573f46553337990c397693985e5004eeecae1) Thanks [@iAmmar7](https://github.com/iAmmar7)! - CF SDK: Expose room layout on the `CallFabriRoomSession` object

### Modified
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### Modified
### Changed

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, can you please update this change in other changelog files as well?

@@ -22,7 +22,7 @@
],
"repository": {
"type": "git",
"url": "https://github.com/signalwire/signalwire-js"
"url": "git+https://github.com/signalwire/signalwire-js.git"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks! I did not know that.

@iAmmar7
Copy link
Collaborator

iAmmar7 commented Feb 3, 2025

Also, can you fix the date in the PR title, please? Release 2025-02-03. We might need to update if we do not merge this PR today.

@jpsantosbh
Copy link
Collaborator Author

Isn't the date the date when we publish to npm?

@iAmmar7
Copy link
Collaborator

iAmmar7 commented Feb 3, 2025

Isn't the date the date when we publish to npm?

True, we release to the NPM when we merge this PR. So, the date needs to change if we merge it tomorrow.

@jpsantosbh
Copy link
Collaborator Author

@iAmmar7 But we did the release already.
this PR is only to sync the main with what has been released.

NPM will reject the new publish with the same version that is already there. so this date is already fine.

@jpsantosbh jpsantosbh requested a review from iAmmar7 February 5, 2025 18:52
@iAmmar7
Copy link
Collaborator

iAmmar7 commented Feb 6, 2025

@iAmmar7 But we did the release already. this PR is only to sync the main with what has been released.

NPM will reject the new publish with the same version that is already there. so this date is already fine.

Alright.

@Devon-White, could you please prepare the release notes and update the docs if that's necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants