Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CF SDK - Implicit reattach #1110

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

CF SDK - Implicit reattach #1110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f5bce8f
CF SDK: Implicit reattach
iAmmar7 Aug 28, 2024
4e29d87
reattach refactor
iAmmar7 Aug 28, 2024
8d99eae
e2e test for reattach
iAmmar7 Aug 28, 2024
3514519
error message
iAmmar7 Aug 29, 2024
edcb3bd
more e2e tests
iAmmar7 Aug 29, 2024
dda5763
more reattach tests
iAmmar7 Aug 30, 2024
de63c70
remove only test
iAmmar7 Aug 30, 2024
0b55199
should fail with wrong call id
iAmmar7 Aug 30, 2024
7f50c68
should with wrong protocol
iAmmar7 Aug 30, 2024
e532b0e
swml tests includes
iAmmar7 Aug 30, 2024
f31899e
remove unnecessary change
iAmmar7 Aug 30, 2024
864c03e
flag update
iAmmar7 Aug 30, 2024
1febaf9
more e2e tests
iAmmar7 Sep 2, 2024
8d57366
Merge branch 'main' into aa/implicit-reattach
iAmmar7 Sep 2, 2024
c276f90
include changeset
iAmmar7 Sep 2, 2024
dbcf8cd
refactor attach logic
iAmmar7 Sep 3, 2024
6dd0efd
remove explicit reattach
iAmmar7 Sep 3, 2024
86abe0b
fix build
iAmmar7 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changeset/poor-months-develop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
'@signalwire/webrtc': minor
'@signalwire/js': minor
---

CF SDK - Implicit call reattach
3 changes: 3 additions & 0 deletions internal/e2e-js/playwright.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,10 @@ const reattachTests = [
]
const callfabricTests = [
'address.spec.ts',
'buildVideoElement.spec.ts',
'conversation.spec.ts',
'reattachWithRoom.spec.ts',
'reattachWithSWML.spec.ts',
'relayApp.spec.ts',
'swml.spec.ts',
'videoRoom.spec.ts',
Expand Down
183 changes: 0 additions & 183 deletions internal/e2e-js/tests/callfabric/reattach.spec.ts
View file
Open in desktop

This file was deleted.

Loading
Loading