[mod_opus] Fix to allow transcoding between different rates #2832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit shows redundant use of Did you mean this instead ? So only opus is affected: See #2582 (comment) regarding #2623. |
|
@celliso1 oh.. my bad. True, it does affect recordings in an unpredictable way like this. I will correct this, thank you. |
In vars.xml , when you use codec settings like this: `<X-PRE-PROCESS cmd="set" data="internal_codec_prefs=OPUS@16000h@1c,PCMU"/>` The switch_core_media.c line 5520 only takes the OPUS default rate (48k) instead of 16k in the config. Because of this, FS won't be able to choose opus if your client asks for 16k opus. You will see same log symptom as signalwire#2226 We've found that the patch signalwire#2582 has the side effect of causing calls that fail to negotiate the same codec as Leg A for Leg B to fail with SIP 488 INCOMPATIBLE_DESTINATION. That's not an option for us, we need backwards compatibility with other codecs. Rather than apply this for all codecs it should only apply for Opus. Now calls using Opus and other codecs establish correctly on both legs, and there are no issues with codec negotiation when the codecs on Leg A and Leg B don't match. Tested-by: Jérôme Poulin <[email protected]> Co-authored-by: magiclin99 <[email protected]>
Allow transcoding between different rate without messing up the RTP timestamps after transcoding kicks-in. @celliso1: It appears this PR (signalwire#2623) has revealed a bug in the opus encoder affecting the timestamp increment. The RFC 7587 states opus always increments at 48kHz regardless of the payload sample rate, but mod_opus.c is using 16 kHz or 8kHz samples per packet. Co-authored-by: celliso1 <[email protected]> Tested-by: Jérôme Poulin <[email protected]>
ticpu
force-pushed
the
mod_opus_transcoding_fixes
branch
from
ad06e74 to
8cd8876
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in relation to #2226 and its discussions.
It includes a comprehensive list of patches that were suggested in isolation but that work better as a whole.
Thanks to @celliso1, @shaunjstokes, @magiclin99 and all others who have contributed to fixing this issue.
Obsoletes: #2582, #2623.
Fixes: #2226