feat(evals): filter spans for eval processing#151
Draft
adityamehra wants to merge 4 commits intomainfrom
Draft
Conversation
wrisa
reviewed
Jan 27, 2026
|
|
||
| if isinstance(entity, LLMInvocation): | ||
| operation = getattr(entity, "operation", None) | ||
| # Only apply filter to chat operations (not embeddings, etc.) |
Contributor
There was a problem hiding this comment.
embedding invocation is a different type, we do not need to check chat for llm invocation type.
Contributor
Author
| def _should_sample_for_evaluation(self, trace_id: Optional[int]) -> bool: | ||
| def _should_sample_for_evaluation(self, entity: GenAI) -> bool: | ||
| # Check if we require parent span for LLM invocations (filters out evaluation library internal calls) | ||
| if self._eval_require_parent_span: |
Contributor
There was a problem hiding this comment.
workflow will also not have parent but IIRC at some point we discussed workflows to be evaluated as well.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR aims to prevent LLM spans not part of the agentic AI applications from overwhelming the eval processor