This repository was archived by the owner on Jan 3, 2023. It is now read-only.
SIGNALFX_ENVIRONMENT env variable tag#34
Open
hackerrdave wants to merge 1 commit intosignalfx:masterfrom
Open
Conversation
…environment root span tag
owais
reviewed
Jun 9, 2020
| 4. (Optional) Set environment variable to set `environment` root span tag | ||
|
|
||
| .. code:: bash | ||
| SIGNALFX_ENVIRONMENT=production |
Contributor
There was a problem hiding this comment.
Do other signalfx libraries also have a SIGNALFX_ENVIRONMENT env var option? I've generally seen other libraries take a comma separated list of arbitary tags and expect users to supply environment as part of that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v2.0 of the APM requires a span tag of
environmentto be set in order to logically categorize service maps. This PR allows optional setting of theenvironmenttag by setting an environment variable ofSIGNALFX_ENVIRONMENTand using its value as the tag value.