Skip to content

First open-source contribution: Fix UI positioning of send and cancel buttons for right-handed accessibility #14093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kavibhagya30
Copy link

First time contributor checklist

Contributor checklist

  • I am following the Code Style Guidelines
  • I have tested my contribution on these devices:
    • (Unable to test directly due to limited setup)
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This is my first open-source contribution!

I noticed an issue with the positioning of the send and cancel buttons in the Signal app, where right-handed users experienced difficulty due to the buttons being placed too far apart, making it tricky to interact with them one-handed. The cancel button was also placed near the send button, causing accidental presses.

Fix:

  • Repositioned the send button closer to the middle for easier one-handed use.
  • Moved the cancel button slightly to prevent accidental presses.

As I am unable to test the changes directly due to setup limitations, I am submitting this PR with the assumption that it addresses the described UI issue. Further testing can be done by contributors or maintainers to verify the effectiveness of the fix.

I hope this helps improve the accessibility and usability of the Signal app for right-handed users.

@Kavibhagya30
Copy link
Author

Greetings maintainers,
This is my first open-source contribution, and I'm really glad to contribute to this project. I noticed a UI issue related to the positioning of the send and cancel buttons for right-handed accessibility that was reported in the Issues section, and I’ve submitted this PR as a fix for it.

Currently, two workflows are awaiting approval. Kindly review and approve them when convenient so that the validations can proceed.

Thank you for your time and support!

@alex-signal
Copy link
Contributor

@Kavibhagya30 Could you please include a screenshot of this solution?

@Kavibhagya30
Copy link
Author

Kavibhagya30 commented Apr 16, 2025 via email

@alex-signal
Copy link
Contributor

@Kavibhagya30 Doesn't seem to have come through, you might need to just post it through github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants