Skip to content

Fix pasting an image into an edited message instead of sending a new copy #14069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

UnreachableCode
Copy link

@UnreachableCode UnreachableCode commented Mar 30, 2025

First time contributor checklist

Contributor checklist

  • Pixel 8, Android 15.
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

I think when the edit message feature was added, the ability to paste an image into the editing message was overlooked. Worth noting that this same bug also exists in the iOS application. I will not be fixing the iOS bug at this time.

For the fix, I've added the edit message ID into ConversationFragment.sendPreUploadMediaMessage(...) for the messageToEdit parameter. This is how it's done in the regular text send. I tested it with several messages in a chat and it now edits the existing message instead of sending a fresh one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants