Fix pasting an image into an edited message instead of sending a new copy #14069
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
I think when the edit message feature was added, the ability to paste an image into the editing message was overlooked. Worth noting that this same bug also exists in the iOS application. I will not be fixing the iOS bug at this time.
For the fix, I've added the edit message ID into
ConversationFragment.sendPreUploadMediaMessage(...)
for the messageToEdit parameter. This is how it's done in the regular text send. I tested it with several messages in a chat and it now edits the existing message instead of sending a fresh one.