Skip to content

Fixes #14051: Preserve search term when refreshing contacts #14055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codewithdipesh
Copy link
Contributor

@codewithdipesh codewithdipesh commented Mar 22, 2025

First time contributor checklist

Contributor checklist

  • Device A, Android X.Y.Z
  • Device B, Android Z.Y
  • Virtual device W, Android Y.Y.Z
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

The fix is straightforward - I've removed the line in RefreshDirectoryTask.onPostExecute() that was explicitly clearing the search field activity.contactFilterView.clear(), while maintaining the call to reset the query filter. This allows the contacts to refresh properly while preserving the user's search term.

I tested the fix by:
-starting a new chat
-Searching for the contact by name (not found initially)
-Clicking "refresh contacts"
-Verifying the search term remained in the search field
-Confirming the newly added contact appears in the filtered results after refresh

The fix was tested on a Pixel 7 Pro running Android 15 with Signal version 7.38.5

@alex-signal
Copy link
Contributor

Thanks! this was pulled into 7.39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants