Fixes #14051: Preserve search term when refreshing contacts #14055
+0
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
Fixes #1234
syntaxDescription
The fix is straightforward - I've removed the line in
RefreshDirectoryTask.onPostExecute()
that was explicitly clearing the search fieldactivity.contactFilterView.clear()
, while maintaining the call to reset the query filter. This allows the contacts to refresh properly while preserving the user's search term.I tested the fix by:
-starting a new chat
-Searching for the contact by name (not found initially)
-Clicking "refresh contacts"
-Verifying the search term remained in the search field
-Confirming the newly added contact appears in the filtered results after refresh
The fix was tested on a Pixel 7 Pro running Android 15 with Signal version 7.38.5