Fixes #14018 - Improve InputPanel Views State management #14023
Conversation
| @@ -569,17 +567,6 @@ public void onRecordPermissionRequired() { | |||
| @Override | |||
| public void onRecordPressed() { | |||
| if (listener != null) listener.onRecorderStarted(); | |||
| recordTime.display(); | |||
There was a problem hiding this comment.
Moved to updateComposeViews function, which is called from ConversationFragment.
| @@ -613,15 +600,20 @@ public void onRecordMoved(float offsetX, float absoluteX) { | |||
| @Override | |||
| public void onRecordCanceled(boolean byUser) { | |||
| Log.d(TAG, "Recording canceled byUser=" + byUser); | |||
| onRecordHideEvent(); | |||
| if (listener != null) listener.onRecorderCanceled(byUser); | |||
| long elapsedTime = onRecordHideEvent(); | |||
There was a problem hiding this comment.
Do not save draft of less than one second
| }); | ||
|
|
||
| return elapsedTime; | ||
| return recordTime.hide(); |
There was a problem hiding this comment.
All recording-related views will be updated from updateComposeViews
| public @Nullable DraftTable.Draft getVoiceNoteDraft() { | ||
| return voiceNoteDraftView.getDraft(); | ||
| } | ||
| public void updateComposeViews() { |
There was a problem hiding this comment.
Making this a single source of truth for updating the views prevents any overlapping of different states.
| @@ -873,7 +911,7 @@ private RecordTime(@NonNull TextView recordTimeView, @NonNull View microphone, l | |||
| public void display() { | |||
| this.startTime = System.currentTimeMillis(); | |||
| this.recordTimeView.setText(DateUtils.formatElapsedTime(0)); | |||
| ViewUtil.fadeIn(this.recordTimeView, FADE_TIME); | |||
| recordTimeView.setVisibility(View.VISIBLE); | |||
There was a problem hiding this comment.
Reason: A consecutive fadeOut and fadeIn call to this makes the timeView invisible. Directly setting the visibility fixed the bug with the minimum amount of work.
| @@ -1663,6 +1645,22 @@ class ConversationFragment : | |||
|
|
|||
| conversationItemDecorations = ConversationItemDecorations(hasWallpaper = args.wallpaper != null) | |||
| binding.conversationItemRecycler.addItemDecoration(conversationItemDecorations, 0) | |||
|
|
|||
There was a problem hiding this comment.
The listener should be set as soon as possible, if not, this was the main reason for overlapping of the states.
The default views were visible, and the listener was not set yet when the recorder was locked quickly.
| @@ -1766,6 +1764,7 @@ class ConversationFragment : | |||
| } | |||
|
|
|||
| private fun updateToggleButtonState() { | |||
| inputPanel.updateComposeViews() | |||
There was a problem hiding this comment.
This is the only place that calls this function.
updateToggleButtonState is called more than updateComposeViews() needs. But, this is a worth tradeoff.
|
Wanted to provide an update that this is a lot of code change to address the original bug report, and I'm nervous to make too many big changes here since this is one of the core interaction points in the app. Could be fine, but we'll just need to take more time to review and test it. |
First time contributor checklist
Contributor checklist
Fixes #1234syntaxDescription