Fix mtda user creation and lava dropin #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the ISAR integration, we change the mtda user to be used for interactive logins. However, this requires a homedir, as usermod does not create a homedir for a user that did not have one before (which is also correct, as the home bootstrapping only happens on adduser). As the ISAR user creation logic is executed after the rootfs install, the postinst script of mtda-service does not know about the mtda user and creates no homedir. Then, when ISAR changes the user, it was created without a home, hence the changed user also not gets any home. By that, the mtda user remains without a home, which leads to various warnings on login. We fix this by always creating the mtda user with a homedir. Fixes: 5bf7a48 ("fix(www): switch from flask to tornado") Signed-off-by: Felix Moessbauer <[email protected]>
When enabling the lava override, it completely clears the IMAGE_PREINSTALL list (except for the lava-dispatcher package). This is because an incorrect append is used (we append to IMAGE_PREINSTALL:lava instead of just appending in case lava is selected). Fixes: 6bf2e42 ("meta-isar: images: make LAVA an optional feature") Signed-off-by: Felix Moessbauer <[email protected]>
chombourger
approved these changes
Mar 13, 2025
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For details, see individual commit messages.