Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storage): session should own the storage after mounting #457

Merged
merged 1 commit into from
Mar 11, 2025
Merged

fix(storage): session should own the storage after mounting #457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions mtda/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,20 +779,20 @@ def storage_mount(self, part=None, **kwargs):

session = kwargs.get("session", None)
self.session_ping(session)
if self.storage.is_storage_mounted is True:
self.mtda.debug(4, "storage_mount(): already mounted")
result = True
elif self.storage is None:
self.mtda.debug(4, "storage_mount(): no shared storage device")
return False
else:

if self.storage is None:
raise RuntimeError('no shared storage device')
elif self.storage.is_storage_mounted is True:
raise RuntimeError("already mounted")
elif self.storage_locked(session) is True:
raise RuntimeError('shared storage in use')
elif self.storage.to_host() is True:
result = self.storage.mount(part)
self._storage_mounted = (result is True)

if self.storage is not None:
self._storage_owner = session
self.storage_locked()

self.mtda.debug(3, f"main.storage_mount(): {str(result)}")
self.mtda.debug(3, f"main.storage_mount(): {result}")
return result

@Pyro4.expose
Expand Down