fixes around storage-flush from www #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cedric Hombourger <[email protected]>
Clients may not call flush(), it is therefore incorrect to send the completion notification from there. It should instead be sent from the writer thread just before it exits. Signed-off-by: Cedric Hombourger <[email protected]>
We have different queues for the data and control planes: the javascript code may have sent the entire file to the websocket but the browser will have it enqueued into its own queue. With calls we make being asynchronous, remove the unnecessary call to the storage-flush endpoint: we will be notified when the agent has finished processing the queue (with a CORRUPTED or INITIALIZED event). Signed-off-by: Cedric Hombourger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.