Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add usbsdmux support #402

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Add usbsdmux support #402

merged 4 commits into from
Feb 16, 2024

Conversation

jan-kiszka
Copy link
Contributor

See patch 1 for details.

@fmoessbauer

@github-actions github-actions bot requested a review from chombourger February 16, 2024 14:57
@chombourger
Copy link
Collaborator

thank you! I was hoping to get one of these for myself. lucky you :)

@chombourger
Copy link
Collaborator

LGTM. Triggered our CI checks before merging.

@jan-kiszka
Copy link
Contributor Author

Wait, I'm missing docs, and I just realized that I still hard-coded /dev/sg0 - one minute...

@chombourger chombourger removed the check label Feb 16, 2024
This brings support for SD muxers using usbsdmux [1]. It is very similar
to the Samsung muxer, and there is at least commercially available
hardware for it [2].

[1] https://github.com/linux-automation/usbsdmux
[2] https://www.linux-automation.com/en/products/usb-sd-mux.html

Signed-off-by: Jan Kiszka <[email protected]>
Nicely packaged by Debian already. Even if that is not the latest
version, it works perfectly.

Signed-off-by: Jan Kiszka <[email protected]>
@jan-kiszka
Copy link
Contributor Author

Now it should be fine.

@chombourger
Copy link
Collaborator

Now it should be fine.

thanks for taking the time to augment the documentation. These are good additions

@chombourger
Copy link
Collaborator

Looks like the spellcheck isn't happy about distros. Replace with distributions to keep the guy happy?

docs/config.rst Outdated

The ``usbsdmux`` driver supports SD card switcher based on the Microchip
USB2642 card reader chip. A tool with this name is available for several
distros and via pip. The following settings are supported:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

distros causes a spellcheck error in the CI. Change to distributions?

Looks like it is currently unused, though.

Signed-off-by: Jan Kiszka <[email protected]>
@chombourger chombourger merged commit 074b660 into siemens:master Feb 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants