Skip to content

Conversation

mxw
Copy link

@mxw mxw commented Aug 6, 2021

it should be there; it's usually set. also delete redundant comments of the form /** the variable name, but with spaces */.

it should be there; it's usually set. also delete redundant comments of the form `/** the variable name, but with spaces */`.
@sidorares
Copy link
Owner

thanks @mxw .
I'm not an expert in TS typings, would it be possible to somehow validate typings from unit tests? Currently if we accidentally break something it's not visible until somebody using this module with TS starts to complain

@mxw
Copy link
Author

mxw commented Aug 7, 2021

i'm just barely aware that unit tests for typings exist, because i happened upon this today: https://github.com/discordjs/discord.js/blob/main/typings/tests.ts

but i'm not familiar with how they work or best practices; i'm a regular TS user but don't maintain any TS libraries myself.

@sidorares

This comment was marked as resolved.

@atlc
Copy link
Contributor

atlc commented Dec 12, 2023

+1 I would love to get this implemented instead of having to setup global overrides just to polyfill that property back in.

@wellwelwel wellwelwel added the needs rebase For internal organization purpose label Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase For internal organization purpose typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants