Return +/- Infinity when a number exceeds the infiniy limits #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andrey,
I'm creating this pull request based on the work that Hao @haoadoresorange did.
@haoadoresorange proposed some improvements after rewriting this project in TypeScript, he is actually busy finishing his graduation thesis (Dorsal laboratory - Polytechnique Montreal), so I will be rewriting them in JavaScript in order to merge them in your main repository.
In this first pull request, we are distinguishing a bad number from an infinite number by returning +/- infinity when the number is higher /lower than the +/- infinity limit.
The unit tests covering that are added too.