Support alwaysParseAsBig with storeAsString #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When alwaysParseAsBig is set to true, and json-bigint encounters a safe number, it doesn't check whether storeAsString is true as well. This PR adds a check for storeAsString, similar to the ternary check when the encountered number is not safe.
I am using json-bigint to parse responses from an API server which passes down raw IDs via an HTTP API. No arithmetic is performed on these IDs, and they're passed back to the server on subsequent HTTP calls. This means storing numbers in the API server's responses as strings is very convenient, and just works when interoping with Node JS's native HTTP module, or with the
requestmodule.A unit tests was also added to ensure this works correctly.