Refactor using import-cost module

[gregorym]

Use import-cost to calculate import sizes. I removed all the unnecessary stuff and did a bit of function renaming.

[gregorym]

Takes care of this issue #2

[reznord]

you have to leave the padding as it is. Since it will disturb the position of the size from the top by 2px.

[gregorym]

it looks pretty wells centered for me.

[reznord]

hmm! Probably because I've changed the font! (but not sure how that can effect)

[gregorym]

I also use a custom font. I just switched to the default font and it looks properly aligned.

[reznord]

yeah, in custom font, it breaks a bit bad :P (but its fine) people hardly change it ;)

[reznord]

LGTM!

[reznord]

@siddharthkp this changes looks good to me. Waiting for your review & merge

[siddharthkp]

Whoops, this completely stopped working for me. Reverted it for now: 30654bc

Let me dig deeper into what happened.

[reznord]

There are a few things:

1. loader is not working (not sure why)
2. This works only when the package is available in node_modules folder.

[gregorym]

How can I repro this issue?

[siddharthkp]

I didn't get time to debug it properly after that 😢

Let me try to get some help with this

[siddharthkp]

This is the error that I was getting.

Failed to require the main module of 'atom-import-cost' because it requires one or more incompatible native modules (binding, binding, binding, binding, binding, binding).
Run `apm rebuild` in the package directory and restart Atom to resolve.

I've published it again as atom-import-cost-beta, can you try if this works for you?

[gregorym]

Ok, i will take a look.

[gregorym]

import-cost has a native dependency that needs to be rebuilt by Atom.. 😢 it works after that.
I'll try to see if there is a work-around.

[gregorym]

One of the dependency of import-cost depends on fsevents which causes the extension to not work after it is installed.

The work around is to rebuild the failing dependency by clicking on the red bug icon at the bottom right of Atom. it is not a great experience but that's the best we can do for now...

Examples:

• Some installed packages could not be loaded because they contain native modules that were compiled for an earlier version of Atom. yongkangchen/remote-sync#434
• fsevents dependency prevents installation TypeStrong/atom-typescript#583

[siddharthkp]

That doesn't sound good 😞

I've been playing with the idea of keeping the installs and bundling on a remote server that uses the same package and talk to it via an API.
We have add an optimisation on top of this which caches the size of package@version on the client.

Cons: Need internet access to get the size of a package@version you are using for the first time.

[reznord]

I was just going through this: https://github.com/electron/electron/blob/master/docs/tutorial/using-native-node-modules.md

Will dig into it more and drop here if I come across something useful.